Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Changing voters and approvers count to 1000 from the default value of 100 #317

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

RakeshUP
Copy link
Contributor

@RakeshUP RakeshUP commented Jan 3, 2024

Description

We need the count of voters and approvers on the tokenVotingProposal and multisigProposal entities to enable pagination and also display the count on the UI without doing multiple queries. Till then using this first: 1000 hack to solve the issue ASAP. @josemarinas @Rekard0

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@RakeshUP RakeshUP added the client-release Publishes the current version of client subpackage on NPM label Jan 3, 2024
josemarinas
josemarinas previously approved these changes Jan 3, 2024
@josemarinas
Copy link
Contributor

josemarinas commented Jan 3, 2024

please @RakeshUP update the version in the package.json befor merging so ir releases a new version of the sdk

Copy link

sonarcloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@josemarinas josemarinas merged commit d1d1ab7 into develop Jan 4, 2024
9 checks passed
@josemarinas josemarinas deleted the f/APP-2585 branch January 4, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants