Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Add missing check #306

Merged
merged 4 commits into from
Nov 24, 2023
Merged

Fix: Add missing check #306

merged 4 commits into from
Nov 24, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Nov 24, 2023 •
edited by jira bot
Loading

Description

Add missing security check in permissions. to address in permission actions should be always the daoAddress
Task ID: OS-874

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@josemarinas josemarinas added the client-release Publishes the current version of client subpackage on NPM label Nov 24, 2023
@josemarinas josemarinas changed the title Feature: Add missing check Fix: Add missing check Nov 24, 2023
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

heueristik
heueristik approved these changes Nov 24, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josemarinas josemarinas merged commit a746bb3 into develop Nov 24, 2023
10 checks passed
@josemarinas josemarinas deleted the fix/OS-874-add-missing-security-check branch November 24, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

Assignees
No one assigned
Labels
client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josemarinas @heueristik