-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: replaces tsdx with dts-cli #304
build: replaces tsdx with dts-cli #304
Conversation
style: replaces tsdx with eslint test: replaces ganache with hardhat feat: upgrades typescript to v5 tests: refactor tests to be time independend tests: uses hardhat global to get provider info test: remove unecessary ts-ignores
build(client:common): updates typescript to v5
build(common): updates typescript to v5
test(ipfs): replaces tsdx with jest lint(ipfs): replaces tsdx with eslint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I saw that you removed the blockchain server start and close, I guess hardhat does not use that, how does the hardhat package launch the test chain? its done automatically or is there a piece of code that i missed?
If so does the blockchain get reseted on each test?
It is baked into the
No, it doesn't for now we have the same setup where is redeploys the contracts as it was before. But definitely a possibility. We could also activate proper fork testing where we don't need to deploy the contracts anymore. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
It replaces tsdx which is not maintained anymore with dts-cli.
It also replaces ganache with hardhat for testing contract calls.
Update workflows to use node 18.
Test workflow now tests the SDK for node 16,18 and 20.
Type of change
Checklist:
CHANGELOG.md
file in the root folder of the package after the[UPCOMING]
title and before the latest version.