Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: replaces tsdx with dts-cli #304

Merged
merged 33 commits into from
Nov 24, 2023

Conversation

mathewmeconry
Copy link
Contributor

@mathewmeconry mathewmeconry commented Nov 22, 2023

Description

It replaces tsdx which is not maintained anymore with dts-cli.
It also replaces ganache with hardhat for testing contract calls.
Update workflows to use node 18.
Test workflow now tests the SDK for node 16,18 and 20.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

style: replaces tsdx with eslint
test: replaces ganache with hardhat
feat: upgrades typescript to v5
tests: refactor tests to be time independend
tests: uses hardhat global to get provider info
test: remove unecessary ts-ignores
build(client:common): updates typescript to v5
build(common): updates typescript to v5
test(ipfs): replaces tsdx with jest
lint(ipfs): replaces tsdx with eslint
@mathewmeconry mathewmeconry changed the title build: replaces tsdx with jest, eslint and rollupjs build: replaces tsdx with dts-cli Nov 22, 2023
Copy link
Contributor

@josemarinas josemarinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I saw that you removed the blockchain server start and close, I guess hardhat does not use that, how does the hardhat package launch the test chain? its done automatically or is there a piece of code that i missed?

If so does the blockchain get reseted on each test?

@mathewmeconry
Copy link
Contributor Author

mathewmeconry commented Nov 24, 2023

Looks good, I saw that you removed the blockchain server start and close, I guess hardhat does not use that, how does the hardhat package launch the test chain? its done automatically or is there a piece of code that i missed?

It is baked into the modules/client/test-environment.ts setup. There it starts hardhat automatically.

If so does the blockchain get reseted on each test?

No, it doesn't for now we have the same setup where is redeploys the contracts as it was before. But definitely a possibility. We could also activate proper fork testing where we don't need to deploy the contracts anymore.

Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mathewmeconry mathewmeconry merged commit 9f4bd43 into develop Nov 24, 2023
10 checks passed
@mathewmeconry mathewmeconry deleted the feat/OS-816-remove-tsdx-in-all-packages branch November 24, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants