Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add getPluginPreparations function #294

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Feature: Add getPluginPreparations function #294

merged 6 commits into from
Oct 25, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Oct 24, 2023 •
edited
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-792

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@josemarinas josemarinas force-pushed the f/OS-792-add-prepared-plugins-query branch from d8e5284 to 9e30b6c Compare October 24, 2023 12:28
@josemarinas josemarinas added client-release Publishes the current version of client subpackage on NPM client-common-release Releases a new version of the client-common package labels Oct 24, 2023
Rekard0
Rekard0 previously approved these changes Oct 24, 2023
View reviewed changes
heueristik
heueristik reviewed Oct 24, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@josemarinas josemarinas merged commit 76b4fc8 into develop Oct 25, 2023
8 checks passed
@josemarinas josemarinas deleted the f/OS-792-add-prepared-plugins-query branch October 25, 2023 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik left review comments

@Rekard0 Rekard0 Rekard0 approved these changes

Assignees
No one assigned
Labels
client-common-release Releases a new version of the client-common package client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josemarinas @Rekard0 @heueristik