Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Update validation functions so they receive actions instead of proposalId #290

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Feature: Update validation functions so they receive actions instead of proposalId #290

merged 3 commits into from
Oct 18, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Oct 17, 2023 •
edited by jira bot
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-774

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

mathewmeconry
mathewmeconry previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@mathewmeconry mathewmeconry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rename findAction() to findActionIndex() because it doesn't return the action but only the index of the action within the actions array.
otherwise LGTM

@josemarinas josemarinas force-pushed the f/OS-774-make-update-validation-functions-receive-actions branch from e2004d5 to e516c98 Compare October 18, 2023 09:08
@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
3.1% 3.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@josemarinas josemarinas added the client-release Publishes the current version of client subpackage on NPM label Oct 18, 2023
heueristik
heueristik suggested changes Oct 18, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a concern being unrelated to the changes of this PR. Let's take time to discuss it and maybe open a follow-up task.

modules/client/test/integration/client/methods.test.ts Show resolved Hide resolved
modules/client/src/internal/client/methods.ts Show resolved Hide resolved
@josemarinas josemarinas merged commit 697caff into develop Oct 18, 2023
7 of 8 checks passed
@josemarinas josemarinas deleted the f/OS-774-make-update-validation-functions-receive-actions branch October 18, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Rekard0 approved these changes

@mathewmeconry mathewmeconry mathewmeconry approved these changes

Assignees
No one assigned
Labels
client-release Publishes the current version of client subpackage on NPM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josemarinas @mathewmeconry @Rekard0 @heueristik