Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Add client input validation #278

Merged
merged 7 commits into from
Oct 9, 2023
Merged

Feature: Add client input validation #278

merged 7 commits into from
Oct 9, 2023

Conversation

josemarinas
Copy link
Contributor

@josemarinas josemarinas commented Sep 1, 2023 •
edited by jira bot
Loading

Description

Please include a summary of the change and be sure you follow the contributions rules we do provide here

Task ID: OS-678

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them when possible.
  • I have updated the CHANGELOG.md file in the root folder of the package after the [UPCOMING] title and before the latest version.
  • I have tested my code on the test network.

@josemarinas josemarinas force-pushed the f/0S-678-add-input-validation-in-client branch from 46a2e0a to a57763b Compare September 1, 2023 10:32
mathewmeconry
mathewmeconry previously requested changes Sep 1, 2023
View reviewed changes
modules/client/src/internal/client/decoding.ts Show resolved Hide resolved
modules/client/src/internal/utils.ts Outdated Show resolved Hide resolved
modules/client/test/integration/client/methods.test.ts Outdated Show resolved Hide resolved
@josemarinas josemarinas force-pushed the f/0S-678-add-input-validation-in-client branch from d61b704 to 7e8a2c6 Compare October 9, 2023 08:42
@sonarcloud
Copy link

sonarcloud bot commented Oct 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

@josemarinas josemarinas dismissed mathewmeconry’s stale review October 9, 2023 13:36

changes were made but mathias was on vacation

@josemarinas josemarinas merged commit 8a4bf30 into develop Oct 9, 2023
8 checks passed
@josemarinas josemarinas deleted the f/0S-678-add-input-validation-in-client branch October 9, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rekard0 Rekard0 Rekard0 approved these changes

@mathewmeconry mathewmeconry mathewmeconry left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josemarinas @mathewmeconry @Rekard0