Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(APP-3648): Connect buttons, explorer layout margin #1410

Merged
merged 3 commits into from
Oct 29, 2024
Merged

fix(APP-3648): Connect buttons, explorer layout margin #1410

merged 3 commits into from
Oct 29, 2024

Conversation

thekidnamedkd
Copy link
Contributor

@thekidnamedkd thekidnamedkd commented Oct 29, 2024 •
edited by jira bot
Loading

Description

Noticed some changes fell out between the two tickets. This is a reconciliation fix-up.

Namely: margin on explorer from hero and the connect buttons having incongruent behavior on responsive sizing.

Task: APP-3648

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I have tested my code on the test network.

@cgero-eth cgero-eth merged commit b8fd00d into develop Oct 29, 2024
3 checks passed
@cgero-eth cgero-eth deleted the fix/explorer-ui branch October 29, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgero-eth cgero-eth cgero-eth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thekidnamedkd @cgero-eth