Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore yt-dlp warnings #245

Merged
merged 1 commit into from
Aug 18, 2023
Merged

Conversation

SimonRask
Copy link
Contributor

The warnings interfere with JSON parsing

Fixes #242

The warnings interfere with JSON parsing

Fixes aquelemiguel#242
@lordzsolt
Copy link

Great.... I just wasted half an afternoon reaching the same conclusion, and was about to open a PR 😅

@aquelemiguel Would be great to have this merged.
As described in #242, yt-dlp will throw warnings like "HTTP 429 Too many requests" into stderr and stdout.

This breaks all the parsing logic that relies on NEWLINE_BYTE, because the output now consists of multiple lines.

@joao-conde joao-conde self-assigned this Aug 18, 2023
@joao-conde joao-conde added the 🐛 bug Something isn't working label Aug 18, 2023
@joao-conde joao-conde self-requested a review August 18, 2023 23:44
@joao-conde
Copy link
Collaborator

Sorry for the delay, this makes absolute sense.
Nasty bug you guys found.
Thanks for the fix.

@joao-conde joao-conde merged commit 0f2022c into aquelemiguel:main Aug 18, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bot is not playing track
3 participants