Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Resolved the issue of the hamburger #1582 #1587

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Conversation

shriyadindi
Copy link
Contributor

@shriyadindi shriyadindi commented Oct 29, 2024

Title : Resolved the issue of the hamburger

Issue No. : #1518

Close #1518

Code Stack : HTML, CSS, JS

Video/Screenshots (mandatory)

Tourguide.-.Brave.2024-10-29.10-49-26.mp4

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit d0c8c87
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/672071d550b070000875264e
😎 Deploy Preview https://deploy-preview-1587--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shriyadindi shriyadindi changed the title Resolved the issue of the hamburger feat: Resolved the issue of the hamburger #1582 Oct 29, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shriyadindi
image

though there are some bugs but still I am merging this pr ,
please try to make a separate pr fixing this bug on this issue

@apu52 apu52 merged commit 9b51929 into apu52:main Oct 29, 2024
8 of 11 checks passed
Copy link

🎉🎉 Thank you for your contribution! Your PR #1587 has been merged! 🎉🎉

@apu52
Copy link
Owner

apu52 commented Oct 29, 2024

@shriyadindi btw great work. really great dedication

@shriyadindi
Copy link
Contributor Author

@apu52 Thank you!

@shriyadindi
Copy link
Contributor Author

shriyadindi commented Oct 29, 2024

@apu52 I'll try to resolve them.

@shriyadindi
Copy link
Contributor Author

shriyadindi commented Oct 29, 2024

@apu52 I've worked on the bug of the navbar.
#1589

apu52 added a commit that referenced this pull request Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Navbar UI and alignment
2 participants