Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Navbar UI and alignment #1518 #1578

Closed
wants to merge 1 commit into from

Conversation

shriyadindi
Copy link
Contributor

@shriyadindi shriyadindi commented Oct 27, 2024

Title : Navbar UI and alignment

I've aligned the elements of the navbar and enhanced the user interface
Code Stack : HTML,, CSS, JS
issue no. : #1518
Before :
Screenshot 2024-10-20 142452

Video/Screenshots (mandatory) AFTER:

Screenshot 2024-10-28 001215

Tourguide.-.Brave.2024-10-28.00-13-55.mp4
  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 27, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 6765783
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/671e8b48bf140500087f3211
😎 Deploy Preview https://deploy-preview-1578--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shriyadindi shriyadindi changed the title navbar alignment and UI feat : navbar alignment and UI Oct 27, 2024
@shriyadindi shriyadindi changed the title feat : navbar alignment and UI [Feature Request]: Navbar UI and alignment Oct 27, 2024
@shriyadindi shriyadindi changed the title [Feature Request]: Navbar UI and alignment feat: Navbar UI and alignment #1518 Oct 27, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shriyadindi actually the changes u have made in the navbar is not looking good , please try to came up with another chance of better UI

image

@shriyadindi
Copy link
Contributor Author

@apu52 Okay

@shriyadindi
Copy link
Contributor Author

@apu Made the changes #1582

@apu52 apu52 closed this Oct 29, 2024
@apu52 apu52 added the invalid This doesn't seem right label Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right review requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants