Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue is resolved #1538

Merged
merged 2 commits into from
Oct 29, 2024
Merged

fix: issue is resolved #1538

merged 2 commits into from
Oct 29, 2024

Conversation

Aditya90456
Copy link
Contributor

@Aditya90456 Aditya90456 commented Oct 20, 2024

now back to home

Close #1521

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 5f9e4ce
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/67208258093c8d00086e7b8a
😎 Deploy Preview https://deploy-preview-1538--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Aditya90456! Thank you for your valuable contribution! Our team will review it and get back to you soon.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aditya90456 the pr form is not correctly filled up .Please try to fill the pr form correctly with all of the details (e.g the issue no. , the features u have added , prototype videos/images etc.) please try to modify your pr with this so that I can merge this pr.

@apu52 apu52 changed the title issue is resolved fix: issue is resolved Oct 26, 2024
@apu52 apu52 added help wanted Extra attention is needed and removed title needs formatting labels Oct 26, 2024
@Aditya90456
Copy link
Contributor Author

@apu52
Copy link
Owner

apu52 commented Oct 28, 2024

i solved issue @apu52 https://github.com/user-attachments/assets/9575ba18-4cce-42df-8054-4bca459ab9fe

Like the changes in the website is not properly shown in the website . Please try to make the video properly & also fill the form up like the details

  1. issue no.
  2. in which open source programme u are contributing
  3. the proper prototype video /ss of your changes

u can take reference from the other PR's format .please check that

Copy link
Contributor Author

@Aditya90456 Aditya90456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no.issue is #1521
I am contributor of GirlScript summer of code

Error.Page.not.found.and.14.more.pages.-.Personal.2.-.Microsoft.Edge.Beta.2024-10-29.12-16-52.mp4

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Aditya90456 good work really great

@apu52 apu52 merged commit 9a92e8d into apu52:main Oct 29, 2024
5 checks passed
@apu52 apu52 added level1 hacktoberfest-accepted gssoc-ext and removed help wanted Extra attention is needed labels Oct 29, 2024
Copy link

🎉🎉 Thank you for your contribution! Your PR #1538 has been merged! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Error page back to homepage functionality
2 participants