Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no nav bar in top deals , issue #1426 #1533

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

Siddhart2004
Copy link
Contributor

Title : No nav bar in top deals

Issue No. :1426

Close #1426

Description

included the nav bar in the top deals page

Video/Screenshots (mandatory)

Before adding the nav bar
image

After adding the nav bar
image

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have gone through the contributing.md file before contributing
  • I have Starred the Repository.

##Are you contributing under any Open-source programme?

  • I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Copy link

netlify bot commented Oct 20, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit d66c3d8
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/671488bdb794ca0008928e37
😎 Deploy Preview https://deploy-preview-1533--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Siddhart2004! Thank you for your valuable contribution! Our team will review it and get back to you soon.

@Siddhart2004 Siddhart2004 changed the title included nav bar in top deals fix:nav bar in top deals Oct 20, 2024
@Siddhart2004 Siddhart2004 changed the title fix:nav bar in top deals fix: no nav bar in top deals , issue #1426 Oct 20, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Siddhart2004 good work

@apu52 apu52 merged commit 6852f5b into apu52:main Oct 25, 2024
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navbar Disappears When Navigating to About and Top Deals Pages
2 participants