Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generating test transactions with move script #775

Open
wants to merge 1 commit into
base: 01-17-importing_test_transactions
Choose a base branch
from

Conversation

yuunlimm
Copy link

@yuunlimm yuunlimm commented Jan 17, 2025

Description

Screenshot 2025-01-17 at 10.50.19 AM.png

Checklist

  • If any existing pages were renamed or removed:
    • Were redirects added to next.config.mjs?
    • Did you update any relative links that pointed to the renamed / removed pages?
  • Do all Lints pass?
    • Have you ran pnpm fmt?
    • Have you ran pnpm lint?

Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developer-docs-nextra ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 7:02pm

@yuunlimm yuunlimm mentioned this pull request Jan 17, 2025
2 tasks
Copy link
Author

yuunlimm commented Jan 17, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@yuunlimm yuunlimm force-pushed the 01-17-generating_test_transactions_with_move_script branch from f346475 to 337099f Compare January 17, 2025 18:50
@yuunlimm yuunlimm marked this pull request as ready for review January 17, 2025 18:50
@yuunlimm yuunlimm requested review from a team, gregnazario, hariria and igor-p as code owners January 17, 2025 18:50
Comment on lines +458 to +461
source:
"/indexer/indexer-sdk/documentation/advanced-tutorials/txn-scripts",
destination:
"/en/build/indexer/indexer-sdk/documentation/advanced-tutorials/txn-scripts",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The redirect paths (txn-scripts) don't match the actual file name (txn-script). This mismatch will cause the redirect to fail. The paths in the redirect configuration should be updated to use txn-script to match the MDX file name.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.


Once the Move files and configuration are set up, run the same command used to import transactions:
- testing-folder is where your Move files are stored.
- output-foler can be set to any folder where you want to store the generated files.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix typo: output-foler should be output-folder in the command line argument description. This documentation error could cause copy/paste issues for developers following these steps.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

@@ -0,0 +1,78 @@
---
title: "Aptos Transaction Import"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title Aptos Transaction Import is inconsistent with the document's content, which focuses on generating test transactions with Move scripts. Consider updating the title to Generating Test Transactions with Move Scripts to accurately reflect the material covered in this guide.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant