Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos and links #772

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/nextra/pages/en/network/blockchain/base-gas.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ In extreme cases it is possible for instruction gas to far outweigh storage gas,

### Payload gas

As of the time of this writing, [`transaction/mod.rs`](https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/aptos-gas-schedule/src/gas_schedule/transaction.rs) defines the minimum amount of internal gas per transaction as 1,500,000 internal units (15,000 [octas](../glossary.mdx#Octa) at minimum), an amount that increases by 2,000 internal gas units (20 octas minimum) per byte for payloads larger than 600 bytes, with the maximum number of bytes permitted in a transaction set at 65536.
As of the time of this writing, [`transaction/mod.rs`](https://github.com/aptos-labs/aptos-core/blob/main/aptos-move/aptos-gas-schedule/src/gas_schedule/transaction.rs) defines the minimum amount of internal gas per transaction as 1,500,000 internal units (15,000 [octas](../glossary.mdx#octa) at minimum), an amount that increases by 2,000 internal gas units (20 octas minimum) per byte for payloads larger than 600 bytes, with the maximum number of bytes permitted in a transaction set at 65536.
Hence, in practice, payload gas is unlikely to be a concern.

[#4540]: https://github.com/aptos-labs/aptos-core/pull/4540/files
Expand Down
6 changes: 3 additions & 3 deletions apps/nextra/pages/en/network/blockchain/gas-txn-fee.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Transactions can range from simple and inexpensive to complicated based upon wha
See [How Base Gas Works](base-gas.mdx) for a detailed description of gas fee types and available optimizations.

<Callout type="info">
👉 A **unit of gas** is a dimensionless number or a unit that is not associated with any one item such as a coin, expressed as an integer. The total gas units consumed by your transaction depend on the complexity of your transaction. The **gas price**, on the other hand, is expressed in terms of Aptos blockchain’s native coin [APT](../glossary.mdx#APT) and it's subunit [Octas](../glossary.mdx#octa). Also see [Transactions and States](txns-states.mdx) for how a transaction submitted to the Aptos blockchain looks like.
👉 A **unit of gas** is a dimensionless number or a unit that is not associated with any one item such as a coin, expressed as an integer. The total gas units consumed by your transaction depend on the complexity of your transaction. The **gas price**, on the other hand, is expressed in terms of Aptos blockchain’s native coin [APT](../glossary.mdx#apt) and it's subunit [Octas](../glossary.mdx#octa). Also see [Transactions and States](txns-states.mdx) for how a transaction submitted to the Aptos blockchain looks like.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word it's should be its here since this is a possessive form ("belonging to it") rather than the contraction of "it is". The phrase should read "its subunit".

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

</Callout>

## The Fee Statement
Expand Down Expand Up @@ -91,7 +91,7 @@ However, within a block, the order of transaction execution is determined by the
When a transaction is submitted to the Aptos blockchain, the transaction must contain the following mandatory gas fields:

- `max_gas_amount`: The maximum number of gas units that the transaction sender is willing to spend to execute the transaction. This determines the maximum computational and storage resources that can be consumed by the transaction.
- `gas_price`: The price per gas unit the transaction sender is willing to pay. It is expressed in[Octas](../glossary.mdx#Octa).
- `gas_price`: The price per gas unit the transaction sender is willing to pay. It is expressed in [Octas](../glossary.mdx#octa).

During the transaction execution, the total gas amount, expressed as:

Expand Down Expand Up @@ -129,7 +129,7 @@ There are some nuances with regard to price changing and legacy slots which didn

It should also be noted that due to some backward compatibility reasons, the total storage fee of a transaction is currently presented to the client as part of the total `gas_used`. This means, this amount could vary based on the gas unit price even for the same transaction.

Here is an example. Suppose we have a transaction that costs `100` gas units in execution & IO, and `5000` [Octas](../glossary.mdx#Octa) in storage fees. The network will show that you have used
Here is an example. Suppose we have a transaction that costs `100` gas units in execution & IO, and `5000` [Octas](../glossary.mdx#octa) in storage fees. The network will show that you have used

- `100 + 5000 / 100 = 150` gas units if the gas unit price is `100`, or
- `100 + 5000 / 200 = 125` gas units if the unit price is `200`.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ Once the beneficiary address is set, the operator commission earned by the deleg

## Check delegation pool information

Until the delegation pool has received 1 million APT and the validator has been added to the set of active validators, there will be no rewards to track during each cycle. In order to obtain information about a delegation pool, use the Aptos [View function](../../../build/apis/fullnode-rest-api.mdx#reading-state-with-the-view-function)
Until the delegation pool has received 1 million APT and the validator has been added to the set of active validators, there will be no rewards to track during each cycle. In order to obtain information about a delegation pool, use the Aptos [View function](../../../../build/apis/fullnode-rest-api.mdx#reading-state-with-the-view-function)

- `get_owned_pool_address(owner: address): address` - Returns the address of the delegation pool belonging to the owner, or produces an error if there is no delegation pool associated with the owner.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ If you are a node operator, there are several tools available to you to verify t

- **REST API:** You can also monitor your node's health by querying the REST API. For example, you can verify the
current block height of your node by pinging the index page of your node's REST API. For more information, see the
[Aptos API Specification](../../fullnode-rest-api-reference.mdx).
[Aptos API Specification](../../../../build/apis/fullnode-rest-api-reference.mdx).

- **Monitoring tools:** To improve observability, you can also install monitoring tools that scrape the local metrics endpoint:
- For Kubernetes based deployments, install the monitoring Helm chart ([https://github.com/aptos-labs/aptos-core/tree/main/terraform/helm/monitoring](https://github.com/aptos-labs/aptos-core/tree/main/terraform/helm/monitoring)).
Expand Down