Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not emitting fungible_asset::Withdraw event when paying gas #15835

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

igor-aptos
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 28, 2025

Copy link
Contributor

@runtian-zhou runtian-zhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering if we could get rid of the generic parameters here as we are always going to just burn APT?

@igor-aptos
Copy link
Contributor Author

coin cannot depend on AptosCoin. Anyways, after migration all for_gas things in coin will disappear.

@igor-aptos igor-aptos enabled auto-merge (squash) January 29, 2025 00:39

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@igor-aptos igor-aptos merged commit b4c4e96 into main Jan 29, 2025
90 checks passed
@igor-aptos igor-aptos deleted the igor/fix_gas_withdraw_event branch January 29, 2025 01:17
github-actions bot pushed a commit that referenced this pull request Jan 29, 2025
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
aptos-release-v1.26

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 34cef945e3affc2822fb05ec2528bac3ddf780ce

two traffics test: inner traffic : committed: 14895.04 txn/s, latency: 2660.73 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3100 ms), latency samples: 5663500
two traffics test : committed: 99.98 txn/s, latency: 1419.26 ms, (p50: 1400 ms, p70: 1400, p90: 1600 ms, p99: 1700 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.429, avg: 1.302", "ConsensusProposalToOrdered: max: 0.292, avg: 0.288", "ConsensusOrderedToCommit: max: 0.417, avg: 0.398", "ConsensusProposalToCommit: max: 0.706, avg: 0.686"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.09s no progress at version 1476 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.72s no progress at version 2810920 (avg 0.72s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 55909aa300b714e37df1113a239332c334cb2896 ==> 34cef945e3affc2822fb05ec2528bac3ddf780ce

Compatibility test results for 55909aa300b714e37df1113a239332c334cb2896 ==> 34cef945e3affc2822fb05ec2528bac3ddf780ce (PR)
1. Check liveness of validators at old version: 55909aa300b714e37df1113a239332c334cb2896
compatibility::simple-validator-upgrade::liveness-check : committed: 12233.93 txn/s, latency: 2569.50 ms, (p50: 2700 ms, p70: 2800, p90: 2900 ms, p99: 3300 ms), latency samples: 398440
2. Upgrading first Validator to new version: 34cef945e3affc2822fb05ec2528bac3ddf780ce
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4410.00 txn/s, latency: 7058.07 ms, (p50: 7800 ms, p70: 8400, p90: 8700 ms, p99: 8800 ms), latency samples: 92320
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4385.18 txn/s, latency: 7741.03 ms, (p50: 8700 ms, p70: 8700, p90: 9100 ms, p99: 9100 ms), latency samples: 154960
3. Upgrading rest of first batch to new version: 34cef945e3affc2822fb05ec2528bac3ddf780ce
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4383.81 txn/s, latency: 7067.86 ms, (p50: 7800 ms, p70: 8400, p90: 8700 ms, p99: 8800 ms), latency samples: 92660
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4344.89 txn/s, latency: 7801.50 ms, (p50: 8800 ms, p70: 8800, p90: 9200 ms, p99: 9200 ms), latency samples: 153000
4. upgrading second batch to new version: 34cef945e3affc2822fb05ec2528bac3ddf780ce
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 2236.60 txn/s, submitted: 2236.78 txn/s, expired: 0.18 txn/s, latency: 4039.57 ms, (p50: 4700 ms, p70: 4900, p90: 5100 ms, p99: 5300 ms), latency samples: 139709
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 7447.60 txn/s, latency: 4613.71 ms, (p50: 5000 ms, p70: 5100, p90: 5200 ms, p99: 5500 ms), latency samples: 249360
5. check swarm health
Compatibility test for 55909aa300b714e37df1113a239332c334cb2896 ==> 34cef945e3affc2822fb05ec2528bac3ddf780ce passed
Test Ok

igor-aptos pushed a commit that referenced this pull request Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants