Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] yaml to disallow init_module to publish modules #15754

Conversation

georgemitenkov
Copy link
Contributor

Description

Enable feature to not allow init_module even attempt to publish modules.

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 16, 2025

⏱️ 29m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-unit-tests 24m 🟩
check-dynamic-deps 3m 🟩
rust-cargo-deny 2m 🟩
general-lints 33s 🟩
semgrep/ci 20s 🟩
file_change_determinator 11s 🟩
permission-check 3s 🟩
permission-check 2s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link

trunk-io bot commented Jan 16, 2025

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@perryjrandall perryjrandall deleted the branch aptos-release-v1.26 January 16, 2025 21:31
@georgemitenkov georgemitenkov deleted the george/disallow-ini-module-to-publish-modules-1.26 branch January 29, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants