Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[buffer manager] move epoch notification to after commit #15746

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

zekun000
Copy link
Contributor

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Copy link

trunk-io bot commented Jan 15, 2025

⏱️ 27m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-doc-tests 6m 🟩
execution-performance / test-target-determinator 6m 🟩
test-target-determinator 5m 🟩
rust-cargo-deny 3m 🟩🟩
check-dynamic-deps 3m 🟩🟩
fetch-last-released-docker-image-tag 2m 🟩
general-lints 51s 🟩🟩
semgrep/ci 51s 🟩🟩
file_change_determinator 20s 🟩🟩
file_change_determinator 11s 🟩
execution-performance / single-node-performance 10s 🟩
permission-check 4s 🟩🟩
permission-check 4s 🟩🟩
permission-check 2s 🟩
determine-docker-build-metadata 2s 🟩

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
execution-performance / single-node-performance 10s 19m -99%

settingsfeedbackdocs ⋅ learn more about trunk.io

@zekun000 zekun000 enabled auto-merge (rebase) January 15, 2025 23:40

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on a01d6889998efa933fa46e54220d9710ce134fbf

two traffics test: inner traffic : committed: 14997.93 txn/s, latency: 2649.28 ms, (p50: 2700 ms, p70: 2700, p90: 2700 ms, p99: 3000 ms), latency samples: 5702620
two traffics test : committed: 99.99 txn/s, latency: 1350.63 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 1600 ms), latency samples: 1760
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.533, avg: 1.501", "ConsensusProposalToOrdered: max: 0.286, avg: 0.284", "ConsensusOrderedToCommit: max: 0.301, avg: 0.293", "ConsensusProposalToCommit: max: 0.586, avg: 0.578"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.51s no progress at version 1270 (avg 0.19s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.57s no progress at version 2262715 (avg 0.57s) [limit 16].
Test Ok

Copy link
Contributor

✅ Forge suite compat success on 6593fb81261f25490ffddc2252a861c994234c2a ==> a01d6889998efa933fa46e54220d9710ce134fbf

Compatibility test results for 6593fb81261f25490ffddc2252a861c994234c2a ==> a01d6889998efa933fa46e54220d9710ce134fbf (PR)
1. Check liveness of validators at old version: 6593fb81261f25490ffddc2252a861c994234c2a
compatibility::simple-validator-upgrade::liveness-check : committed: 17516.29 txn/s, latency: 1979.97 ms, (p50: 2100 ms, p70: 2100, p90: 2400 ms, p99: 3600 ms), latency samples: 568380
2. Upgrading first Validator to new version: a01d6889998efa933fa46e54220d9710ce134fbf
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 4643.41 txn/s, latency: 6692.32 ms, (p50: 7500 ms, p70: 8000, p90: 8300 ms, p99: 8500 ms), latency samples: 95140
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 4671.62 txn/s, latency: 7309.27 ms, (p50: 8200 ms, p70: 8200, p90: 8500 ms, p99: 8600 ms), latency samples: 166920
3. Upgrading rest of first batch to new version: a01d6889998efa933fa46e54220d9710ce134fbf
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 4455.53 txn/s, latency: 6798.19 ms, (p50: 7800 ms, p70: 8000, p90: 8500 ms, p99: 8600 ms), latency samples: 100040
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 4388.11 txn/s, latency: 7720.73 ms, (p50: 8600 ms, p70: 8900, p90: 9100 ms, p99: 9300 ms), latency samples: 153440
4. upgrading second batch to new version: a01d6889998efa933fa46e54220d9710ce134fbf
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 9368.04 txn/s, latency: 3250.88 ms, (p50: 3800 ms, p70: 3900, p90: 4100 ms, p99: 4200 ms), latency samples: 167500
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 9024.54 txn/s, latency: 3793.16 ms, (p50: 4100 ms, p70: 4100, p90: 4300 ms, p99: 4500 ms), latency samples: 299500
5. check swarm health
Compatibility test for 6593fb81261f25490ffddc2252a861c994234c2a ==> a01d6889998efa933fa46e54220d9710ce134fbf passed
Test Ok

@zekun000 zekun000 merged commit ea88731 into main Jan 16, 2025
90 checks passed
@zekun000 zekun000 deleted the zekun/fix branch January 16, 2025 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants