Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cargo nextest version #15608

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Fix cargo nextest version #15608

merged 1 commit into from
Dec 16, 2024

Conversation

vineethk
Copy link
Contributor

@vineethk vineethk commented Dec 15, 2024

Description

Not able to release CLI: https://github.com/aptos-labs/aptos-core/actions/runs/12335989799, because the current rust version 1.78.0 is not supported by the nextest version installed.

Copy link

trunk-io bot commented Dec 15, 2024

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vineethk vineethk marked this pull request as ready for review December 15, 2024 19:09
@vineethk vineethk requested a review from a team as a code owner December 15, 2024 19:09
Copy link
Contributor

@gregnazario gregnazario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently looking into finishing upgrading to 1.83 but this fixes it for now

@vineethk vineethk enabled auto-merge (squash) December 15, 2024 23:46

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

✅ Forge suite compat success on 3c6e693a27339e73520f41030dce8fc9cd504967 ==> dfd66cfebbc32a355bd70a9e7f43beb28630f8c6

Compatibility test results for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> dfd66cfebbc32a355bd70a9e7f43beb28630f8c6 (PR)
1. Check liveness of validators at old version: 3c6e693a27339e73520f41030dce8fc9cd504967
compatibility::simple-validator-upgrade::liveness-check : committed: 15397.76 txn/s, latency: 2180.48 ms, (p50: 1700 ms, p70: 1900, p90: 2600 ms, p99: 19600 ms), latency samples: 527240
2. Upgrading first Validator to new version: dfd66cfebbc32a355bd70a9e7f43beb28630f8c6
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7427.43 txn/s, latency: 3892.49 ms, (p50: 4300 ms, p70: 4500, p90: 4600 ms, p99: 4700 ms), latency samples: 141180
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7326.00 txn/s, latency: 4384.60 ms, (p50: 4700 ms, p70: 4700, p90: 4800 ms, p99: 4800 ms), latency samples: 252980
3. Upgrading rest of first batch to new version: dfd66cfebbc32a355bd70a9e7f43beb28630f8c6
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 6768.11 txn/s, latency: 4173.25 ms, (p50: 4700 ms, p70: 4900, p90: 5400 ms, p99: 5600 ms), latency samples: 125440
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7105.71 txn/s, latency: 4613.40 ms, (p50: 5000 ms, p70: 5000, p90: 5200 ms, p99: 5300 ms), latency samples: 233080
4. upgrading second batch to new version: dfd66cfebbc32a355bd70a9e7f43beb28630f8c6
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10214.83 txn/s, latency: 2707.98 ms, (p50: 2500 ms, p70: 3000, p90: 4100 ms, p99: 4300 ms), latency samples: 183220
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10700.28 txn/s, latency: 2921.40 ms, (p50: 2600 ms, p70: 3600, p90: 4100 ms, p99: 4500 ms), latency samples: 354740
5. check swarm health
Compatibility test for 3c6e693a27339e73520f41030dce8fc9cd504967 ==> dfd66cfebbc32a355bd70a9e7f43beb28630f8c6 passed
Test Ok

Copy link
Contributor

✅ Forge suite realistic_env_max_load success on dfd66cfebbc32a355bd70a9e7f43beb28630f8c6

two traffics test: inner traffic : committed: 14777.03 txn/s, latency: 2688.39 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3300 ms), latency samples: 5618560
two traffics test : committed: 100.00 txn/s, latency: 1471.89 ms, (p50: 1300 ms, p70: 1400, p90: 1500 ms, p99: 4800 ms), latency samples: 1780
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.602, avg: 1.500", "ConsensusProposalToOrdered: max: 0.322, avg: 0.291", "ConsensusOrderedToCommit: max: 0.300, avg: 0.293", "ConsensusProposalToCommit: max: 0.591, avg: 0.584"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.14s no progress at version 46145 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.57s no progress at version 2002172 (avg 0.53s) [limit 16].
Test Ok

@vineethk vineethk merged commit 5711729 into main Dec 16, 2024
90 checks passed
@vineethk vineethk deleted the vk/fix-nextest-version branch December 16, 2024 00:17
bchocho pushed a commit that referenced this pull request Dec 17, 2024
sherry-x pushed a commit that referenced this pull request Dec 18, 2024
georgemitenkov pushed a commit that referenced this pull request Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants