Linter returns non-zero exit code on warnings (#15761)

aptos-labs · Jan 16, 2025 · 4b69e48 · 4b69e48
1 parent fbf0256
commit 4b69e48
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/aptos-move/framework/src/built_package.rs b/aptos-move/framework/src/built_package.rs
@@ -272,7 +272,7 @@ impl BuiltPackage {
 
             if let Some(model_options) = model.get_extension::<Options>() {
                 if model_options.experiment_on(Experiment::STOP_BEFORE_EXTENDED_CHECKS) {
-                    std::process::exit(0)
+                    std::process::exit(if model.has_warnings() { 1 } else { 0 })
                 }
             }
 
@@ -287,7 +287,7 @@ impl BuiltPackage {
 
             if let Some(model_options) = model.get_extension::<Options>() {
                 if model_options.experiment_on(Experiment::STOP_AFTER_EXTENDED_CHECKS) {
-                    std::process::exit(0)
+                    std::process::exit(if model.has_warnings() { 1 } else { 0 })
                 }
             }
 

diff --git a/third_party/move/move-compiler-v2/src/lib.rs b/third_party/move/move-compiler-v2/src/lib.rs
@@ -102,7 +102,7 @@ where
     check_errors(&env, emitter, "checking errors")?;
 
     if options.experiment_on(Experiment::STOP_BEFORE_STACKLESS_BYTECODE) {
-        std::process::exit(0)
+        std::process::exit(if env.has_warnings() { 1 } else { 0 })
     }
 
     // Run code generator
@@ -140,7 +140,7 @@ where
     check_errors(&env, emitter, "stackless-bytecode analysis errors")?;
 
     if options.experiment_on(Experiment::STOP_BEFORE_FILE_FORMAT) {
-        std::process::exit(0)
+        std::process::exit(if env.has_warnings() { 1 } else { 0 })
     }
 
     let modules_and_scripts = run_file_format_gen(&mut env, &targets);