Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add done checkbox to parent issue page #230

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Add done checkbox to parent issue page #230

wants to merge 16 commits into from

Commits on May 21, 2015

  1. Refactor the way the 'watch' checkbox works. On the UI side this is i… 

    …mplemented as a checkbox within a link. Clicking on it calls a view on the server, then reloads the existing page with the change applied. This makes it possible to have such action happen on clicking a tick box (rather than then having to press submit) without relying on javascript. So far this approach was only used for the 'watch' box. As we are introducing the same functionality for the 'done' checkbox, there could be a need for some refactoring. This is an experiment at finding a small refactoring, which formalizes this approach without trying to change the way it's implemented. As such it names such 'checkbox' action Single Action Views, and moves them in a file of their own, with their own base class. It may be that this is not the best approach, and either no refactoring, or rethinking the way this is implemented is a more adequate course of action.
    @aliceh75
    aliceh75 committed May 21, 2015
    Configuration menu
    Copy the full SHA
    f0df5d2 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #1 from aliceh75/action_item_done_checkbox 

    Refactor the way the 'watch' checkbox works. On the UI side this is i…
    @daniell
    daniell committed May 21, 2015
    Configuration menu
    Copy the full SHA
    68feede View commit details
    Browse the repository at this point in the history

  3. Fix broken tests

    @daniell
    daniell committed May 21, 2015
    Configuration menu
    Copy the full SHA
    c677f41 View commit details
    Browse the repository at this point in the history

  4. Update watcher views require a login

    @daniell
    daniell committed May 21, 2015
    Configuration menu
    Copy the full SHA
    e5222a2 View commit details
    Browse the repository at this point in the history

  5. Tidy html

    @daniell
    daniell committed May 21, 2015
    Configuration menu
    Copy the full SHA
    7f9ab0b View commit details
    Browse the repository at this point in the history

  6. ActionItem set/unset views work

    @daniell
    daniell committed May 21, 2015
    Configuration menu
    Copy the full SHA
    a01cb4a View commit details
    Browse the repository at this point in the history

  7. ActionItem actions views return 404 if item doesn't exist

    @daniell
    daniell committed May 21, 2015
    Configuration menu
    Copy the full SHA
    9075a45 View commit details
    Browse the repository at this point in the history

  8. Make Watcher views throw 404 if decision not found

    @daniell
    daniell committed May 21, 2015
    Configuration menu
    Copy the full SHA
    d4f5a6d View commit details
    Browse the repository at this point in the history

Commits on May 22, 2015

  1. Add boxes to mark or unmark action items as done

    @daniell
    daniell committed May 22, 2015
    Configuration menu
    Copy the full SHA
    c7714c0 View commit details
    Browse the repository at this point in the history

  2. Write tests for SetActionItemDone view

    @daniell
    daniell committed May 22, 2015
    Configuration menu
    Copy the full SHA
    0986cfb View commit details
    Browse the repository at this point in the history

  3. Add tests for UnsetActionItemDone view

    @daniell
    daniell committed May 22, 2015
    Configuration menu
    Copy the full SHA
    369a8a1 View commit details
    Browse the repository at this point in the history

  4. Remove duplicate tests

    @daniell
    daniell committed May 22, 2015
    Configuration menu
    Copy the full SHA
    c6ba056 View commit details
    Browse the repository at this point in the history

  5. Ensure that users can't watch items for orgs they don't belong to

    @daniell
    daniell committed May 22, 2015
    Configuration menu
    Copy the full SHA
    02eb272 View commit details
    Browse the repository at this point in the history

  6. Ensure users can't alter action items for decisions for orgs they don't 

    belong to.
    @daniell
    daniell committed May 22, 2015
    Configuration menu
    Copy the full SHA
    e7f546b View commit details
    Browse the repository at this point in the history

Commits on May 26, 2015

  1. Fix broken tests

    @daniell
    daniell committed May 26, 2015
    Configuration menu
    Copy the full SHA
    37b6c15 View commit details
    Browse the repository at this point in the history

  2. Use last version of astroid compatible with python 2.6

    @daniell
    daniell committed May 26, 2015
    Configuration menu
    Copy the full SHA
    2ae9053 View commit details
    Browse the repository at this point in the history