-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add done checkbox to parent issue page #230
Open
daniell
wants to merge
16
commits into
aptivate:develop
Choose a base branch
from
daniell:add_done_checkbox_to_parent_issue_page
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add done checkbox to parent issue page #230
daniell
wants to merge
16
commits into
aptivate:develop
from
daniell:add_done_checkbox_to_parent_issue_page
Commits on May 21, 2015
-
Refactor the way the 'watch' checkbox works. On the UI side this is i…
…mplemented as a checkbox within a link. Clicking on it calls a view on the server, then reloads the existing page with the change applied. This makes it possible to have such action happen on clicking a tick box (rather than then having to press submit) without relying on javascript. So far this approach was only used for the 'watch' box. As we are introducing the same functionality for the 'done' checkbox, there could be a need for some refactoring. This is an experiment at finding a small refactoring, which formalizes this approach without trying to change the way it's implemented. As such it names such 'checkbox' action Single Action Views, and moves them in a file of their own, with their own base class. It may be that this is not the best approach, and either no refactoring, or rethinking the way this is implemented is a more adequate course of action.
Configuration menu - View commit details
-
Copy full SHA for f0df5d2 - Browse repository at this point
Copy the full SHA f0df5d2View commit details -
Merge pull request #1 from aliceh75/action_item_done_checkbox
Refactor the way the 'watch' checkbox works. On the UI side this is i…
Configuration menu - View commit details
-
Copy full SHA for 68feede - Browse repository at this point
Copy the full SHA 68feedeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c677f41 - Browse repository at this point
Copy the full SHA c677f41View commit details -
Configuration menu - View commit details
-
Copy full SHA for e5222a2 - Browse repository at this point
Copy the full SHA e5222a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f9ab0b - Browse repository at this point
Copy the full SHA 7f9ab0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for a01cb4a - Browse repository at this point
Copy the full SHA a01cb4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9075a45 - Browse repository at this point
Copy the full SHA 9075a45View commit details -
Configuration menu - View commit details
-
Copy full SHA for d4f5a6d - Browse repository at this point
Copy the full SHA d4f5a6dView commit details
Commits on May 22, 2015
-
Configuration menu - View commit details
-
Copy full SHA for c7714c0 - Browse repository at this point
Copy the full SHA c7714c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0986cfb - Browse repository at this point
Copy the full SHA 0986cfbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 369a8a1 - Browse repository at this point
Copy the full SHA 369a8a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6ba056 - Browse repository at this point
Copy the full SHA c6ba056View commit details -
Configuration menu - View commit details
-
Copy full SHA for 02eb272 - Browse repository at this point
Copy the full SHA 02eb272View commit details -
Configuration menu - View commit details
-
Copy full SHA for e7f546b - Browse repository at this point
Copy the full SHA e7f546bView commit details
Commits on May 26, 2015
-
Configuration menu - View commit details
-
Copy full SHA for 37b6c15 - Browse repository at this point
Copy the full SHA 37b6c15View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ae9053 - Browse repository at this point
Copy the full SHA 2ae9053View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.