docs: Remove setEndpoint #1223
docs: Remove setEndpoint #1223
Conversation
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2024-08-21 02:53:09 CET |
…moval of .setEndpoint/.set_endpoint
…nsistency. fix comment formatting to reflect placeholder variables replacement
choir241
force-pushed
the
docs-remove-endpoint
branch
from
bf3a25b
to
7e4bec3
Compare
| @@ -189,14 +189,12 @@ struct FooPackage { | |||
| static let account = Account(client) | |||
|
|
|||
| public static func login( | |||
| endpoint: String, | |||
There was a problem hiding this comment.
Where login() is used will probably need to be updated.
| .setProject('<PROJECT_ID>') // Your project ID | ||
| .setJWT('eyJJ9.eyJ...886ca'); // Your secret JSON Web Token | ||
| .setProject('<PROJECT_ID>') // Your project ID | ||
| .setJWT('eyJJ9.eyJ...886ca'); // Your secret JSON Web Token |
There was a problem hiding this comment.
Let's use <USER_JWT> placeholder
| @@ -58,7 +58,6 @@ object Appwrite { | |||
|
|
|||
| fun init(context: Context) { | |||
| client = Client(context) | |||
| .setEndpoint(ENDPOINT) | |||
There was a problem hiding this comment.
we don't need the const anymore, right?
| @@ -102,7 +102,6 @@ object Appwrite { | |||
|
|
|||
| fun init(context: Context) { | |||
| client = Client(context) | |||
| .setEndpoint("https://cloud.appwrite.io/v1") | |||
There was a problem hiding this comment.
please update the [YOUR_PROJECT_ID] placeholder too
| @@ -110,7 +110,6 @@ class Appwrite { | |||
|
|
|||
| public init() { | |||
| self.client = Client() | |||
| .setEndpoint("https://cloud.appwrite.io/v1") | |||
There was a problem hiding this comment.
please update the [YOUR_PROJECT_ID] placeholder too
| @@ -25,7 +25,6 @@ export const SESSION_COOKIE = "my-custom-session"; | |||
|
|
|||
| export function createAdminClient() { | |||
| const client = new Client() | |||
| .setEndpoint(process.env.APPWRITE_ENDPOINT!) | |||
There was a problem hiding this comment.
Other parts of the tutorial needs to be updated too since this is removed, right?
| @@ -66,7 +66,7 @@ const project: string = import.meta.env.VITE_APPWRITE_PROJECT; | |||
|
|
|||
| const client: Client = new Client(); | |||
|
|
|||
| client.setEndpoint(url).setProject(project); | |||
There was a problem hiding this comment.
the const and env var can be removed, right?
| @@ -51,7 +51,7 @@ const APPWRITE_PROJECT = "<YOUR_PROJECT_ID>"; // Replace with your project ID | |||
|
|
|||
| const appwriteClient = new Appwrite(); | |||
|
|
|||
| appwriteClient.setEndpoint(APPWRITE_URL).setProject(APPWRITE_PROJECT); | |||
There was a problem hiding this comment.
Other parts of the tutorial needs to be updated too since this is removed, right?
| @@ -21,7 +21,6 @@ import { Databases, Account, Client } from "appwrite"; | |||
|
|
|||
| const client = new Client(); | |||
| client | |||
| .setEndpoint(PUBLIC_APPWRITE_ENDPOINT) | |||
There was a problem hiding this comment.
Other parts of the tutorial needs to be updated too since this is removed, right?
| @@ -27,7 +27,6 @@ export const SESSION_COOKIE = 'my-custom-session'; | |||
|
|
|||
| export function createAdminClient() { | |||
| const client = new Client() | |||
| .setEndpoint(PUBLIC_APPWRITE_ENDPOINT) | |||
There was a problem hiding this comment.
Other parts of the tutorial needs to be updated too since this is removed, right?
What does this PR do?
Remove setEndpoint() from all code examples
Test Plan
X
Related PRs and Issues
X
Have you read the Contributing Guidelines on issues?
Yes