Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: email form sender #49

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Fix: email form sender #49

merged 1 commit into from
Sep 11, 2023

Conversation

Meldiron
Copy link
Contributor

@Meldiron Meldiron commented Sep 9, 2023

What does this PR do?

Fixes behaviour of SMTP sender in HTML contact form

Test Plan

  • Manual on QA server

Related PRs and Issues

x

Have you read the Contributing Guidelines on issues?

Yes

@loks0n
Copy link
Member

loks0n commented Sep 11, 2023 •
edited
Loading

Sending form as contact emailer is fairly common.
If not - maybe we should add reply_to instead?

@loks0n loks0n self-requested a review September 11, 2023 07:59
@Meldiron
Copy link
Contributor Author

During QA I noticed it always went to spam as unauthorized.
We should either use smtp username, or make sender name & email configurable.

Considering it should be simple starter template, I think it's fine to take smtp username as default, and they can change it in the code if needed.

@christyjacob4 christyjacob4 merged commit f8e0c5e into main Sep 11, 2023
This was referenced Oct 1, 2023
Closed
Closed
@loks0n loks0n deleted the fix-mail-form branch October 3, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loks0n loks0n loks0n approved these changes

@christyjacob4 christyjacob4 christyjacob4 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Meldiron @loks0n @christyjacob4