Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat implement storage cleaner node #242

Merged
merged 18 commits into from
Oct 27, 2023

Conversation

Gilbishkosma
Copy link

@Gilbishkosma Gilbishkosma commented Oct 16, 2023

What does this PR do?

This is a PR for the issue #227.
In this i had to create a template to removes all files from the buckets older than X number of days.

Test Plan

I have tested the function template in Appwrite Cloud,
I created 5buckets and added 10images on each bucket, then deleted the files by executing the template.
Here is the video for it: demo video

Related PRs and Issues

This is a PR for the issue #227

Have you read the Contributing Guidelines on issues?

Yes, i have Read the contribution guide.

@Gilbishkosma
Copy link
Author

The only concern i have for this template is that it will take time more than 15minutes(this is the maximum execution time for a function) in case the number of files to be deleted is more than 2k. Cause currently there is no method to do bulk delete in appwrite.

Copy link
Contributor

@Meldiron Meldiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested some important changes, let's apply those. Feel free to continue discussion if you are not onboard with my approach.

@Gilbishkosma
Copy link
Author

@Meldiron i have pushed the recommended changes

node/storage-cleaner/src/appwrite.js Outdated Show resolved Hide resolved
node/storage-cleaner/src/appwrite.js Show resolved Hide resolved
Copy link
Member

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing PR! Few small things before we merge

node/storage-cleaner/src/appwrite.js Outdated Show resolved Hide resolved
node/storage-cleaner/src/util.js Outdated Show resolved Hide resolved
node/storage-cleaner/src/util.js Outdated Show resolved Hide resolved
@Gilbishkosma
Copy link
Author

@loks0n I have pushed the requested changes

@loks0n loks0n merged commit 3d125a3 into appwrite:main Oct 27, 2023
@loks0n
Copy link
Member

loks0n commented Oct 27, 2023

🥳 Merged!

Thanks for your contribution.

@Gilbishkosma
Copy link
Author

Thanks a lot @loks0n , @Meldiron , @gewenyu99 , @stnguyen90, @Haimantika 😇.
I really enjoyed working on this PR and thanks for the PR watch parties.

@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@Gilbishkosma
Copy link
Author

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@gewenyu99 my discord username is: gilbish

@gewenyu99
Copy link

Be in touch soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants