Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: php/whatsapp_with_vonage #239

Merged

Conversation

SoNiC-HeRE
Copy link
Contributor

@SoNiC-HeRE SoNiC-HeRE commented Oct 15, 2023

What does this PR do?

Added php/whatsapp-with-vonage function template

Test Plan

Record_2023-10-15-20-31-09.mp4
Kooha-2023-10-15-11-09-56.webm

Related PRs and Issues

Close #206

Have you read the Contributing Guidelines on issues?

yes

Copy link

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

php/whatsapp-with-vonage/src/index.php Outdated Show resolved Hide resolved
php/whatsapp-with-vonage/src/index.php Outdated Show resolved Hide resolved
php/whatsapp-with-vonage/src/index.php Outdated Show resolved Hide resolved
php/whatsapp-with-vonage/src/index.php Outdated Show resolved Hide resolved
php/whatsapp-with-vonage/src/index.php Outdated Show resolved Hide resolved
@SoNiC-HeRE
Copy link
Contributor Author

Changes Made:

  • Used firebase/php-jwt for Jwt verification and payload check
  • Used response codes where necessary
  • Applied consistent styling and indentation
  • Removed extra/unused code

php/whatsapp-with-vonage/src/index.php Outdated Show resolved Hide resolved
php/whatsapp-with-vonage/src/index.php Outdated Show resolved Hide resolved
php/whatsapp-with-vonage/src/index.php Show resolved Hide resolved
@SoNiC-HeRE
Copy link
Contributor Author

Hi @stnguyen90 , I've addressed the minor changes you suggested and improved the code a bit. Would love to have a final review for this.

Copy link

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 awesome work on your PR! We've approved your work and it'll be merged soon!

@loks0n loks0n merged commit 456687b into appwrite:main Oct 26, 2023
@SoNiC-HeRE
Copy link
Contributor Author

SoNiC-HeRE commented Nov 16, 2023

Discord Id:
SnIpEzzz

@gewenyu99
Copy link

Be in touch soon. Putting together some last minute stuff.

@SoNiC-HeRE
Copy link
Contributor Author

Be in touch soon. Putting together some last minute stuff.

Please let me know if more details are required. Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add WhatsApp with Vonage for PHP
5 participants