Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: sync with meilisearch for ruby #233

Merged
merged 6 commits into from
Nov 2, 2023
Merged

feat: sync with meilisearch for ruby #233

merged 6 commits into from
Nov 2, 2023

Conversation

afzal442
Copy link
Contributor

@afzal442 afzal442 commented Oct 10, 2023 •
edited
Loading

What does this PR do?

Fixes #196

Test Vid:

appwrite_temp_rb.mp4

@loks0n loks0n self-requested a review October 13, 2023 10:14
loks0n
loks0n requested changes Oct 13, 2023
View reviewed changes
Copy link
Member

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've added some comments for you to address

ruby/meilisearch/config.rb Outdated Show resolved Hide resolved
ruby/meilisearch/Gemfile Outdated Show resolved Hide resolved
ruby/meilisearch/lib/utils.rb Outdated Show resolved Hide resolved
ruby/meilisearch/lib/main.rb Outdated Show resolved Hide resolved
@afzal442 afzal442 marked this pull request as draft October 13, 2023 14:38
@afzal442 afzal442 marked this pull request as ready for review October 18, 2023 12:41
@afzal442 afzal442 requested a review from loks0n October 18, 2023 12:41
loks0n
loks0n requested changes Oct 23, 2023
View reviewed changes
Copy link
Member

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also provide a test video showing the function executing on Appwrite

ruby/sync_with_meilisearch/lib/utils.rb Outdated Show resolved Hide resolved
@afzal442 afzal442 requested a review from loks0n October 27, 2023 18:56
@afzal442 afzal442 force-pushed the feat-implement-sync-with-meilisearch-ruby branch from 5404a34 to b612d9d Compare October 27, 2023 19:06
loks0n
loks0n requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also provide a test video showing the function executing on Appwrite

@afzal442
Copy link
Contributor Author

Sorry @loks0n I have been getting this below error. Yesterday, there were no issues, working fine. Any help?

Error 400
Execution error: Server Error

Type

general_argument_invalid

Otherwise, it's working fine.

@afzal442 afzal442 requested a review from loks0n October 31, 2023 15:51
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
@afzal442 afzal442 force-pushed the feat-implement-sync-with-meilisearch-ruby branch from 25e8b52 to 4fce47f Compare November 2, 2023 08:37
@afzal442
Copy link
Contributor Author

afzal442 commented Nov 2, 2023 •
edited
Loading

Hi @loks0n a test video added in the issue desc box. Plz review it.
Link https://653cc78bf40b1c8c8f58.appwrite.global/

@loks0n loks0n merged commit 6dab35f into appwrite:main Nov 2, 2023
@afzal442 afzal442 deleted the feat-implement-sync-with-meilisearch-ruby branch November 2, 2023 15:40
@github-actions github-actions bot mentioned this pull request Dec 1, 2023
Closed
@afzal442
Copy link
Contributor Author

afzal442 commented Apr 7, 2024

my discord id is afzal442

cc @tessamero

@gewenyu99
Copy link

Thanks, be in touch soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loks0n loks0n loks0n approved these changes

Assignees

@afzal442 afzal442

Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add Sync with Meilisearch for Ruby
3 participants
@afzal442 @gewenyu99 @loks0n