Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Sync with meilisearch in bun runtime #223

Merged

Conversation

FreSauce
Copy link
Contributor

@FreSauce FreSauce commented Oct 6, 2023

What does this PR do?

Adds a template for Sync With Meilisearch function in bun runtime.

Test Plan

The template demo is deployed here: https://651ef5e34237d8219e7e.appwrite.global/
Test video: https://drive.google.com/file/d/1Zs4uDsRY-XEvX84smaHI3MjGdfYBTEwF/preview

Related PRs and Issues

This is related to Issue #186

Have you read the Contributing Guidelines on issues?

Yes

bun/sync-with-meilisearch/src/utils.ts Outdated Show resolved Hide resolved
bun/sync-with-meilisearch/src/utils.ts Outdated Show resolved Hide resolved
bun/sync-with-meilisearch/src/utils.ts Outdated Show resolved Hide resolved
bun/sync-with-meilisearch/src/utils.ts Outdated Show resolved Hide resolved
bun/sync-with-meilisearch/env.d.ts Outdated Show resolved Hide resolved
@FreSauce FreSauce requested a review from loks0n October 9, 2023 18:55
bun/sync-with-meilisearch/src/main.ts Outdated Show resolved Hide resolved
bun/sync-with-meilisearch/src/utils.ts Outdated Show resolved Hide resolved
@FreSauce FreSauce requested a review from loks0n October 18, 2023 10:05
bun/sync-with-meilisearch/package.json Outdated Show resolved Hide resolved
bun/sync-with-meilisearch/README.md Outdated Show resolved Hide resolved
bun/sync-with-meilisearch/README.md Outdated Show resolved Hide resolved
@loks0n
Copy link
Member

loks0n commented Oct 23, 2023

Great PR, some small changes required!

@FreSauce
Copy link
Contributor Author

Made the changes, sorry for so many PR review requests.

@FreSauce FreSauce requested a review from loks0n October 23, 2023 14:48
Copy link
Member

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final query :D 🚀

Comment on lines +14 to +15
"path": "^0.12.7",
"url": "^0.11.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these?
We want to do things the bun way

@tessamero tessamero linked an issue Nov 2, 2023 that may be closed by this pull request
6 tasks
@loks0n loks0n merged commit fddce5d into appwrite:main Nov 16, 2023
@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@FreSauce
Copy link
Contributor Author

Hey, my discord id is fresauce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🚀 Feature: Add Sync with Meilisearch for Bun
3 participants