Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat : Implement sync with Meilisearch using php #222

Merged

Conversation

Harsh3341
Copy link
Contributor

@Harsh3341 Harsh3341 commented Oct 6, 2023

What does this PR do?

Implement a sync with meilisearch using php

Test Plan

Screencast.from.23-10-23.03.14.41.PM.IST.webm

Related PRs and Issues

#194

Have you read the Contributing Guidelines on issues?

Yes

@Harsh3341
Copy link
Contributor Author

will commit some changes

@Harsh3341
Copy link
Contributor Author

Harsh3341 commented Oct 6, 2023

@gewenyu99 I wrote the required code, but now for testing, I ran the appwrite locally created a new function, and uploaded sync-with-meilisearch there as a .gz file then it is built successfully, now when I try to visit the deployed domain with /index.php
I receive the below error in execution

Unsupported logs detected. Use $context->log() or $context->error() for logging.
Warning: file_get_contents(/index.html): Failed to open stream: No such file or directory in /usr/local/server/src/function/src/utils.php on line 14

@loks0n
Copy link
Member

loks0n commented Oct 9, 2023

@gewenyu99 I wrote the required code, but now for testing, I ran the appwrite locally created a new function, and uploaded sync-with-meilisearch there as a .gz file then it is built successfully, now when I try to visit the deployed domain with /index.php I receive the below error in execution

Unsupported logs detected. Use $context->log() or $context->error() for logging.
Warning: file_get_contents(/index.html): Failed to open stream: No such file or directory in /usr/local/server/src/function/src/utils.php on line 14

This is telling you that the file_get_contents call is not working. If you are struggling to debug the issue please reach out on our community discord for assistance

@loks0n loks0n self-requested a review October 9, 2023 09:00
@Harsh3341 Harsh3341 force-pushed the feat-implement-sync-with-meilisearch-php branch from 06a2b8d to c38a55c Compare October 17, 2023 20:20
Copy link
Member

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a test video

@Harsh3341
Copy link
Contributor Author

Please provide a test video

Yup, added a video and also readme

Copy link
Member

@loks0n loks0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small changes

php/sync-with-meilisearch/src/index.php Outdated Show resolved Hide resolved
php/sync-with-meilisearch/src/index.php Outdated Show resolved Hide resolved
php/sync-with-meilisearch/src/index.php Outdated Show resolved Hide resolved
@Harsh3341
Copy link
Contributor Author

Just a few small changes

Done :shipit:

@loks0n loks0n self-requested a review October 23, 2023 13:32
@loks0n
Copy link
Member

loks0n commented Oct 23, 2023

Amazing - thanks for your contribution!

@Harsh3341
Copy link
Contributor Author

Discord Username - .harshgupta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants