Flutter CLI #82
Draft
Flutter CLI #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abnegate
reviewed
May 19, 2023
lib/commands/flutter.js
Outdated
Comment on lines
15
to
17
| const appwriteFile = 'aW1wb3J0ICdwYWNrYWdlOmFwcHdyaXRlL2FwcHdyaXRlLmRhcnQnOwoKZmluYWwgY2xpZW50ID0gQ2xpZW50KCkKICAuc2V0RW5kcG9pbnQoJ3tFTkRQT0lOVH0nKQogIC5zZXRQcm9qZWN0KCd7UFJPSkVDVH0nKTsKCmZpbmFsIGFjY291bnQgPSBBY2NvdW50KGNsaWVudCk7CmZpbmFsIGRhdGFiYXNlcyA9IERhdGFiYXNlcyhjbGllbnQpOwpmaW5hbCBzdG9yYWdlID0gU3RvcmFnZShjbGllbnQpOwoK'; | ||
|
|
||
| const modelTemplate = 'JUlNUE9SVFMlCmNsYXNzICVOQU1FJSB7CiAgZmluYWwgU3RyaW5nICRpZDsKICBmaW5hbCBTdHJpbmcgJGNyZWF0ZWRBdDsKICBmaW5hbCBTdHJpbmcgJHVwZGF0ZWRBdDsKICBmaW5hbCBTdHJpbmcgJGNvbGxlY3Rpb25JZDsKICBmaW5hbCBTdHJpbmcgJGRhdGFiYXNlSWQ7CiAgZmluYWwgTGlzdDxTdHJpbmc+ICRwZXJtaXNzaW9uczsKCiAgJUFUVFJJQlVURVMlCgogICVOQU1FJSh7CiAgICByZXF1aXJlZCB0aGlzLiRpZCwKICAgIHJlcXVpcmVkIHRoaXMuJGNyZWF0ZWRBdCwKICAgIHJlcXVpcmVkIHRoaXMuJHVwZGF0ZWRBdCwKICAgIHJlcXVpcmVkIHRoaXMuJGNvbGxlY3Rpb25JZCwKICAgIHJlcXVpcmVkIHRoaXMuJHBlcm1pc3Npb25zLAogICAgcmVxdWlyZWQgdGhpcy4kZGF0YWJhc2VJZCwKICAgICVDT05TVFJVQ1RPUl9QQVJBTUVURVJTJQogIH0pOwoKICBmYWN0b3J5ICVOQU1FJS5mcm9tTWFwKE1hcDxTdHJpbmcsIGR5bmFtaWM+IG1hcCkgewogICAgcmV0dXJuICVOQU1FJSgKICAgICAgJGlkOiBtYXBbJ1wkaWQnXSwKICAgICAgJGNyZWF0ZWRBdDogbWFwWydcJGNyZWF0ZWRBdCddLAogICAgICAkdXBkYXRlZEF0OiBtYXBbJ1wkdXBkYXRlZEF0J10sCiAgICAgICRjb2xsZWN0aW9uSWQ6IG1hcFsnXCRjb2xsZWN0aW9uSWQnXSwKICAgICAgJHBlcm1pc3Npb25zOiBMaXN0PFN0cmluZz4uZnJvbShtYXBbJ1wkcGVybWlzc2lvbnMnXSksCiAgICAgICRkYXRhYmFzZUlkOiBtYXBbJ1wkZGF0YWJhc2VJZCddLAogICAgICAlQ09OU1RSVUNUT1JfQVJHVU1FTlRTJQogICAgKTsKICB9CgogIE1hcDxTdHJpbmcsIGR5bmFtaWM+IHRvTWFwKCkgewogICAgcmV0dXJuIHsKICAgICAgJ1wkaWQnOiAkaWQsCiAgICAgICdcJGNyZWF0ZWRBdCc6ICRjcmVhdGVkQXQsCiAgICAgICdcJHVwZGF0ZWRBdCc6ICR1cGRhdGVkQXQsCiAgICAgICdcJGNvbGxlY3Rpb25JZCc6ICRjb2xsZWN0aW9uSWQsCiAgICAgICdcJHBlcm1pc3Npb25zJzogJHBlcm1pc3Npb25zLAogICAgICAnXCRkYXRhYmFzZUlkJzogJGRhdGFiYXNlSWQsCiAgICAgICVNQVBfRklFTERTJQogICAgfTsKICB9CgogIEBvdmVycmlkZQogIFN0cmluZyB0b1N0cmluZygpIHsKICAgIHJldHVybiAnJU5BTUUlICcgKyB0b01hcCgpLnRvU3RyaW5nKCk7CiAgfQp9'; |
There was a problem hiding this comment.
Is it possible to include the raw templates by themselves to be more transparent?
There was a problem hiding this comment.
We can do that, I felt this was better than managing multiple files?
There was a problem hiding this comment.
We can do that, I felt this was better than managing multiple files?
Updated to use files instead.
abnegate
reviewed
May 19, 2023
lib/commands/flutter.js
Outdated
Comment on lines
163
to
168
| .replaceAll('%NAME%', name) | ||
| .replace('%IMPORTS%', imports) | ||
| .replace('%ATTRIBUTES%', properties) | ||
| .replace('%CONSTRUCTOR_PARAMETERS%', constructorParams) | ||
| .replace('%CONSTRUCTOR_ARGUMENTS%', constructorArgs) | ||
| .replace('%MAP_FIELDS%', mapFields); |
There was a problem hiding this comment.
Could we do this with a map and a loop instead to make it more extensible?
abnegate
reviewed
May 19, 2023
lib/commands/flutter.js
Outdated
| if (!answers.project) process.exit(1) | ||
|
|
||
| let project = {}; | ||
| if (answers.start == "new") { |
There was a problem hiding this comment.
Let's use === everywhere applicable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
appwrite flutter configurecommand is used to setup Flutter project, link with appwrite project, add platforms and add and initialize Appwrite SDKappwrite flutter generateis used to generate Dart classes for all the database collections in the projectGiving it a try
As it is still under development, if you would like to give it a try please use the following command to install (You will need Node and NPM installed)
Test Plan
(Write your test plan here. If you changed any code, please provide us with clear instructions on how you verified your changes work.)
Related PRs and Issues
(If this PR is related to any other PR or resolves any issue or related to any issue link all related PR and issues here.)
Have you read the Contributing Guidelines on issues?
(Write your answer here.)