Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move css vars from body style tag to separate style node #219

Open
wants to merge 2 commits into
base: v2
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions v2/pink-sb/src/lib/Root.svelte
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
<script lang="ts">
export let theme: Record<string, string>;

$: Object.keys(theme).forEach((key) => {
document.documentElement.style.setProperty(`--${key}`, theme[key]);
});
$: {
const cssVariables = Object.keys(theme)
.map((key) => `--${key}: ${theme[key]};`)
.join(' ');
const styleElement = document.createElement('style');
document.head.prepend(styleElement);
styleElement.textContent = `:root {${cssVariables}}`;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will be creating a style element each time this is triggered.

Maybe we can try and use the <svelte:head /> special element.

<svelte:head>
	<style>{style}</style>
</svelte:head>

</script>

<svelte:head>
Expand Down
Loading