Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to PNPM #124

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,17 @@ jobs:
- name: Checkout Repo
uses: actions/checkout@v3

- uses: pnpm/[email protected]
with:
version: 8.6.3

- name: Setup Node.js 16.x
uses: actions/setup-node@v3
with:
node-version: 16.x

- name: Install Dependencies
run: npm ci
run: pnpm install --frozen-lockfile

- name: Create Release Pull Request or Publish to npm
id: changesets
Expand Down
9 changes: 6 additions & 3 deletions .github/workflows/tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,17 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: pnpm/[email protected]
with:
version: 8.6.3
- name: Use Node.js
uses: actions/setup-node@v2
with:
node-version: 16
- name: Install dependencies
run: npm ci
run: pnpm install --frozen-lockfile
- name: Run Linter
run: npm run lint
run: pnpm run lint
continue-on-error: true
- name: Build packages
run: npm run build
run: pnpm run build
8 changes: 4 additions & 4 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -93,25 +93,25 @@ After installing [Node.js](https://nodejs.org/), run the following commands to s
```sh
git clone https://github.com/appwrite/pink.git
cd pink
npm install
pnpm install
```

### Development

This command can be used to develop Pink Design components with an auto-reload preview exposed at [http://localhost:3333](http://localhost:3333).

Both applications inherit styles and icons respectively from the ui and icon packages. Changes made to these packages will also affect the applications. Styles and icons are taken from the `dist/` folder so `npm run build` must be run to be able to see updates.
Both applications inherit styles and icons respectively from the ui and icon packages. Changes made to these packages will also affect the applications. Styles and icons are taken from the `dist/` folder so `pnpm run build` must be run to be able to see updates.

```sh
npm run dev
pnpm run dev
```

### Build

You can build Pink Design, including all dependencies in [`packages/`](packages/), with:

```sh
npm run build
pnpm run build
```

## Submit a Pull Request 🚀
Expand Down
2 changes: 1 addition & 1 deletion apps/kitchensink/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"author": "",
"license": "ISC",
"devDependencies": {
"@appwrite.io/fonts": "*",
"@appwrite.io/fonts": "workspace:*",
"@appwrite.io/pink": "0.1.0",
"@appwrite.io/pink-icons": "0.1.0",
"vite-plugin-handlebars": "^1.6.0"
Expand Down
6 changes: 4 additions & 2 deletions apps/pink/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,15 @@
"astro": "^1.6.15",
"astro-m2dx": "^0.7.15",
"minisearch": "^6.0.0",
"prismjs": "^1.29.0",
"remark-directive": "^2.0.1",
"svelte": "^3.55.0",
"svelte-codemirror-editor": "^1.1.0",
"tippy.js": "^6.3.7"
"tippy.js": "^6.3.7",
"prettier": "^2.8.2"
},
"devDependencies": {
"@appwrite.io/fonts": "*",
"@appwrite.io/fonts": "workspace:*",
"@appwrite.io/pink": "0.1.0",
"@appwrite.io/pink-icons": "0.1.0",
"@types/prismjs": "^1.26.0",
Expand Down
2 changes: 1 addition & 1 deletion apps/pink/public/search.json

Large diffs are not rendered by default.

Loading
Loading