fix: Telemetry opt-out (#62)

apptension · Jul 5, 2024 · f632f18 · f632f18
1 parent b45a619
commit f632f18
Show file tree

Hide file tree

Showing 3 changed files with 6,931 additions and 9,736 deletions.
diff --git a/package.json b/package.json
@@ -19,12 +19,12 @@
     "@oclif/core": "^2.15.0",
     "@oclif/plugin-help": "^5.2.19",
     "@oclif/plugin-version": "^1.3.10",
-    "@opentelemetry/api": "^1.6.0",
-    "@opentelemetry/exporter-trace-otlp-proto": "^0.43.0",
-    "@opentelemetry/resources": "^1.17.0",
-    "@opentelemetry/sdk-trace-base": "^1.17.0",
-    "@opentelemetry/sdk-trace-node": "^1.17.0",
-    "@opentelemetry/semantic-conventions": "^1.17.0",
+    "@opentelemetry/api": "1.6.0",
+    "@opentelemetry/exporter-trace-otlp-proto": "0.43.0",
+    "@opentelemetry/resources": "1.17.0",
+    "@opentelemetry/sdk-trace-base": "1.17.0",
+    "@opentelemetry/sdk-trace-node": "1.17.0",
+    "@opentelemetry/semantic-conventions": "1.17.0",
     "enquirer": "^2.4.1",
     "fs-extra": "^11.1.1",
     "listr2": "^5.0.8",

diff --git a/src/config/index.ts b/src/config/index.ts
@@ -12,8 +12,11 @@ export const GITHUB_REPOSITORY = `https://github.com/${GH_REPO_OWNER}/${GH_REPO_
 
 const IS_CI = Boolean(process.env.CI ?? false);
 
-export const SB_TELEMETRY_DISABLED = IS_CI || (Boolean(process.env.SB_TELEMETRY_DISABLED) ?? false);
-export const SB_TELEMETRY_DEBUG = IS_CI || (Boolean(process.env.SB_TELEMETRY_DEBUG) ?? false);
+const envTrueValues = new Set(['1', 'true']);
+
+export const SB_TELEMETRY_DISABLED =
+  IS_CI || envTrueValues.has((process.env.SB_TELEMETRY_DISABLED ?? 'false').toLowerCase());
+export const SB_TELEMETRY_DEBUG = IS_CI || envTrueValues.has((process.env.SB_TELEMETRY_DEBUG ?? 'false').toLowerCase());
 const [telemetryUrl, telemetryKey] = telemetryConfig;
 export const SB_TELEMETRY_URL = process.env.SB_TELEMETRY_URL ?? telemetryUrl;
 export const SB_TELEMETRY_KEY = process.env.SB_TELEMETRY_KEY ?? telemetryKey;