-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implemented lookup table for finite field inversion #7
Open
michiexile
wants to merge
1
commit into
appliedtopology:master
Choose a base branch
from
michiexile:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,13 +18,14 @@ | |
* !!! DO NOT CITE THE USER MANUAL !!! | ||
******************************************************************************* | ||
* Copyright (C) Ryan H. Lewis 2014 <[email protected]> | ||
* Mikael Vejdemo-Johansson 2016 <[email protected]> | ||
******************************************************************************* | ||
* Released under BSD-3 License. See LICENSE | ||
*******************************************************************************/ | ||
#include <iostream> | ||
#include <array> | ||
|
||
//TODO: Ensure things here are efficient. | ||
//TODO: possibly provide a generic multiplication table | ||
//TODO: Specialize for N=2 | ||
|
||
//forward declarations | ||
|
@@ -57,6 +58,43 @@ std::size_t inverse( const ctl::Finite_field< N> & x, const std::size_t prime){ | |
return inverse( x.value(), prime); | ||
} | ||
|
||
// Singleton carrying the inversion lookup table | ||
template< std::size_t _prime> | ||
class InverterTable { | ||
private: | ||
std::array< std::size_t, _prime > _inversion_table = {{0}}; | ||
|
||
InverterTable< _prime >( ) { | ||
for(std::size_t i=1; i<_prime; i++) { | ||
_inversion_table[i] = ctl::detail::inverse(i, _prime); | ||
} | ||
}; | ||
|
||
InverterTable< _prime >(InverterTable< _prime > const&); | ||
void operator=(InverterTable< _prime > const&); | ||
|
||
public: | ||
static InverterTable< _prime >& getInstance() { | ||
static InverterTable< _prime > instance; | ||
return instance; | ||
} | ||
std::size_t inverse(std::size_t x) const { | ||
return _inversion_table[x % _inversion_table.size()]; | ||
} | ||
}; | ||
|
||
// Wrapper allowing us to Just Instantiate something to call | ||
template< std::size_t _prime> | ||
class Inverter { | ||
public: | ||
Inverter< _prime >( ) { } | ||
std::size_t inverse(std::size_t x) const { | ||
return InverterTable< _prime >::getInstance().inverse(x); | ||
} | ||
std::size_t inverse(const ctl::Finite_field< _prime >& x) const { | ||
return this->inverse(x.value()); | ||
} | ||
}; | ||
} //detail namespace | ||
} //ctl namespace | ||
|
||
|
@@ -66,6 +104,7 @@ template< std::size_t _prime> | |
class Finite_field{ | ||
private: | ||
typedef Finite_field< _prime> Self; | ||
const detail::Inverter< _prime > inverter; | ||
public: | ||
Finite_field(){} | ||
|
||
|
@@ -152,16 +191,16 @@ class Finite_field{ | |
|
||
template< typename T> | ||
Self operator/(const T& rhs) const{ | ||
return *this*ctl::detail::inverse( rhs, _prime); | ||
return *this*inverter.inverse( rhs ); | ||
} | ||
|
||
template< typename T> | ||
Self& operator/=(const T& rhs){ | ||
*this= *this*ctl::detail::inverse( rhs, _prime); | ||
*this= *this*inverter.inverse( rhs ); | ||
return *this; | ||
} | ||
|
||
Self inverse() const{ return Self( ctl::detail::inverse( x, _prime)); } | ||
Self inverse() const{ return Self( inverter.inverse( x )); } | ||
|
||
const std::size_t prime() const { return _prime; } | ||
const std::size_t value() const { return x; } | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CTL uses the snake_case convention, and the use of singletons is un-necessary here.
You can do something like this:
the compiler will just instantiate one (or lookup the value) when it is used..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ctl::detail::inverse(_) just needs to be constexpr..