We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We have the following code for serializing and deserializing the subjectKeyIdentifier option in CMSSignerIdentifier:
subjectKeyIdentifier
CMSSignerIdentifier
swift-certificates/Sources/X509/CryptographicMessageSyntax/CMSSignerIdentifier.swift
Lines 58 to 62 in d8799da
Lines 39 to 45 in d8799da
Both of these perform explicit tagging of the field. That's informed by this declaration from RFC 5652 § 12.1:
SignerIdentifier ::= CHOICE { issuerAndSerialNumber IssuerAndSerialNumber, subjectKeyIdentifier [0] SubjectKeyIdentifier }
However, this misses that the tags default for the document is specified as:
DEFINITIONS IMPLICIT TAGS ::=
So the default tag is implicit unless one of the exceptions from ITU 680 § 30.6 applies. None of them do, so this should be implicitly tagged.
The text was updated successfully, but these errors were encountered:
8210859
Successfully merging a pull request may close this issue.
We have the following code for serializing and deserializing the
subjectKeyIdentifier
option inCMSSignerIdentifier
:swift-certificates/Sources/X509/CryptographicMessageSyntax/CMSSignerIdentifier.swift
Lines 58 to 62 in d8799da
swift-certificates/Sources/X509/CryptographicMessageSyntax/CMSSignerIdentifier.swift
Lines 39 to 45 in d8799da
Both of these perform explicit tagging of the field. That's informed by this declaration from RFC 5652 § 12.1:
However, this misses that the tags default for the document is specified as:
So the default tag is implicit unless one of the exceptions from ITU 680 § 30.6 applies. None of them do, so this should be implicitly tagged.
The text was updated successfully, but these errors were encountered: