Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Toyota shared credentials #853

Merged
merged 4 commits into from
Jan 27, 2025
Merged

Add Toyota shared credentials #853

merged 4 commits into from
Jan 27, 2025

Conversation

ezfe
Copy link
Contributor

@ezfe ezfe commented Nov 14, 2024 •
edited
Loading

Overall Checklist

@rmondello rmondello self-requested a review November 15, 2024 03:37
rmondello
rmondello requested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@rmondello rmondello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The right way to do this would be to find the AppID of the app and add an entry to apple-appIDs-to-domains-shared-credentials.json for toyota.com.

@ezfe
Copy link
Contributor Author

ezfe commented Nov 15, 2024

All set

@rmondello rmondello merged commit cd7d329 into apple:main Jan 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmondello rmondello rmondello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ezfe @rmondello