Dast new api integration #1508

future-pirate-king · 2024-12-19T06:24:20Z

No description provided.

coderabbitai · 2024-12-19T06:24:28Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

cloudflare-workers-and-pages · 2025-01-09T13:52:14Z

Deploying irenestaging with Cloudflare Pages

Latest commit:	`63cf40d`
Status:	✅ Deploy successful!
Preview URL:	https://3f4ed6c0.irenestaging.pages.dev
Branch Preview URL:	https://pd-1623-dast-new-api-integra.irenestaging.pages.dev

View logs

sonarqubecloud · 2025-01-15T05:06:55Z

Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.7% Duplication on New Code

See analysis details on SonarQube Cloud

Yibaebi · 2025-01-15T21:14:15Z

app/components/project-settings/general-settings/device-preferences-automated-dast/index.hbs

+            @onChange={{this.handleSelectDeviceType}}
+            data-test-projectSettings-generalSettings-devicePreferenceAutomatedDast-automatedPreferenceCriteria-deviceTypeRadioGroup
+            as |ctx|
+          >


Can we use translations for the labels?

Yibaebi · 2025-01-15T21:55:07Z

app/models/file.ts

+  @belongsTo('dynamicscan', { async: true, inverse: null })
+  declare lastManualDynamicScan: AsyncBelongsTo<DynamicscanModel> | null;
+
+  async getLastDynamicScan(


Should this function exist in the model since we already have the last manual and automated scan models in the file response?

In the scheduled scan scenario, we can move the fetching to the Dynamic Scan service, I’d like to think since that is the only use for this function. Please correct me if I am wrong about this.

Yibaebi · 2025-01-15T22:56:56Z

app/services/dynamic-scan.ts

+
+import type FileModel from 'irene/models/file';
+import type OrganizationService from './organization';
+import DynamicscanModel from 'irene/models/dynamicscan';


Add type to import.

app/templates/authenticated/dashboard/file/dynamic-scan/scheduled-automated.hbs

mirage/factories/dynamicscan.ts

Yibaebi · 2025-01-15T23:46:49Z

tests/unit/services/dynamic-scan-test.js

+    });
+
+    // Mock file reload method
+    let reloadCalled = false;


Add space below. In other parts of this file also.

future-pirate-king force-pushed the PD-1623-dast-new-api-integration branch 9 times, most recently from 245c847 to 5543844 Compare December 26, 2024 04:44

future-pirate-king force-pushed the PD-1623-dast-new-api-integration branch 13 times, most recently from e70abfc to 5cf783e Compare January 9, 2025 04:45

avzz-19 force-pushed the PD-1623-dast-new-api-integration branch from e4b7a51 to 161d678 Compare January 9, 2025 13:12

future-pirate-king force-pushed the PD-1623-dast-new-api-integration branch 2 times, most recently from 6453f5d to be0ce2d Compare January 9, 2025 13:52

github-actions bot deployed to irenestorybook (Preview) January 9, 2025 13:54 View deployment

future-pirate-king force-pushed the PD-1623-dast-new-api-integration branch from be0ce2d to 277929c Compare January 9, 2025 17:38

github-actions bot deployed to irenestorybook (Preview) January 9, 2025 17:41 View deployment

future-pirate-king force-pushed the PD-1623-dast-new-api-integration branch 2 times, most recently from 9498f77 to 56ca540 Compare January 13, 2025 11:08

github-actions bot deployed to irenestorybook (Preview) January 13, 2025 11:11 View deployment

future-pirate-king force-pushed the PD-1623-dast-new-api-integration branch from 56ca540 to 93c6dfd Compare January 13, 2025 15:29

github-actions bot deployed to irenestorybook (Preview) January 13, 2025 15:31 View deployment

future-pirate-king force-pushed the PD-1623-dast-new-api-integration branch from 93c6dfd to d4503c4 Compare January 14, 2025 06:06

github-actions bot deployed to irenestorybook (Preview) January 14, 2025 06:08 View deployment

new dast api integration changes

63cf40d

future-pirate-king force-pushed the PD-1623-dast-new-api-integration branch from d4503c4 to 63cf40d Compare January 15, 2025 05:05

github-actions bot deployed to irenestorybook (Preview) January 15, 2025 05:08 View deployment

Yibaebi requested changes Jan 16, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dast new api integration #1508

Dast new api integration #1508

future-pirate-king commented Dec 19, 2024

coderabbitai bot commented Dec 19, 2024 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

cloudflare-workers-and-pages bot commented Jan 9, 2025 •

edited

Loading

sonarqubecloud bot commented Jan 15, 2025

Yibaebi Jan 15, 2025

Yibaebi Jan 15, 2025

Yibaebi Jan 15, 2025

Yibaebi Jan 15, 2025

Dast new api integration #1508

Are you sure you want to change the base?

Dast new api integration #1508

Conversation

future-pirate-king commented Dec 19, 2024

coderabbitai bot commented Dec 19, 2024 • edited Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

cloudflare-workers-and-pages bot commented Jan 9, 2025 • edited Loading

Deploying irenestaging with Cloudflare Pages

sonarqubecloud bot commented Jan 15, 2025

Quality Gate passed

Yibaebi Jan 15, 2025

Choose a reason for hiding this comment

Yibaebi Jan 15, 2025

Choose a reason for hiding this comment

Yibaebi Jan 15, 2025

Choose a reason for hiding this comment

Yibaebi Jan 15, 2025

Choose a reason for hiding this comment

coderabbitai bot commented Dec 19, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

cloudflare-workers-and-pages bot commented Jan 9, 2025 •

edited

Loading