New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enclose HTTP listener address in brackets to allow for IPv6 addresses #27

Merged

mcorbin merged 1 commit into appclacks:master from gecio:http-listener-ipv6-support

Sep 25, 2023

Contributor

SRv6d commented Sep 15, 2023

The HTTP listener currently does not support IPv6 addresses due to colon(:) ambiguity:

{"level":"error","ts":1694782381.9328856,"caller":"http/root.go:136","msg":"HTTP server error: listen tcp: address ::1:9013: too many colons in address","stacktrace":"github.com/appclacks/cabourotte/http.(*Component).Start.func1\n\t/go/cabourotte/http/root.go:136"}

This PR simply adds [] so the address/port combination can be parsed correctly and has no effect on IPv4 listeners.


          Enclose HTTP listener address in brackets to allow for IPv6 addresses

a9721f3

mcorbin merged commit c91a028 into appclacks:master

2 checks passed

Collaborator

mcorbin commented Sep 25, 2023

Thank you for your contribution.

SRv6d deleted the http-listener-ipv6-support branch

September 25, 2023 12:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet