Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove leader election #168

Closed
wants to merge 1 commit into from
Closed

Conversation

jmelis
Copy link
Contributor

@jmelis jmelis commented Oct 5, 2022

No description provided.

@openshift-ci openshift-ci bot requested review from hlipsig and npecka October 5, 2022 09:17
@openshift-ci
Copy link

openshift-ci bot commented Oct 5, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jmelis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Oct 5, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #168 (49b02e6) into master (64242a6) will increase coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #168      +/-   ##
==========================================
+ Coverage   24.37%   24.59%   +0.21%     
==========================================
  Files          19       19              
  Lines         681      675       -6     
==========================================
  Hits          166      166              
+ Misses        498      492       -6     
  Partials       17       17              
Impacted Files Coverage Δ
cmd/manager/main.go 0.00% <ø> (ø)

@nikhil-thomas
Copy link
Contributor

i have fixed some nits and this pr is part of #170

we can close this one and merge #170

@nikhil-thomas
Copy link
Contributor

/hold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants