Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added bucketObjectsACL options to s3.js #56

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Added bucketObjectsACL options to s3.js #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/storage/s3.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ module.exports = function() {
var cachingTime;
var https;
var bucket;
var bucketObjectsACL;
var endpoint;
var defaultTypes;
var noProtoEndpoint;
Expand All @@ -26,6 +27,7 @@ module.exports = function() {
options.credentials = new AWS.Credentials(options.key, options.secret, options.token || null);
}
bucket = options.bucket;
bucketObjectsACL = options.bucketObjectsACL || "public-read";
options.params = options.params || {};
options.params.Bucket = options.params.Bucket || options.bucket;
// bc for the `endpoint`, `secure` and `port` options
Expand Down Expand Up @@ -86,7 +88,7 @@ module.exports = function() {
var inputStream = fs.createReadStream(localPath);

var params = {
ACL: 'public-read',
ACL: bucketObjectsACL,
Key: cleanKey(path),
Body: inputStream,
ContentType: contentType
Expand Down