PRO-6870 Export Templates #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValJed
commented
Jan 6, 2025
| return this.moduleName === '@apostrophecms/page' && !this.type | ||
| ? [ ...new Set(this.checkedTypes) ] | ||
| : [ this.type ]; | ||
| return this.checkedTypes || [ this.type ]; |
There was a problem hiding this comment.
checkedTypes is passed when meant to be used (like for pages and templates).
ValJed
force-pushed
the
pro-6870-export-templates
branch
from
268580e to
92d77f4
Compare
ValJed
force-pushed
the
pro-6870-export-templates
branch
from
5f6536e to
cd5cd9e
Compare
ValJed
commented
Jan 7, 2025
| @@ -151,7 +151,7 @@ export default { | |||
| }, | |||
| checkedTypes: { | |||
| type: Array, | |||
| default: () => [] | |||
| default: null | |||
There was a problem hiding this comment.
checkedTypes must be null and unused unless passed from another component.
| name="fade" | ||
| :duration="200" | ||
| name="slide" | ||
| duration="200" |
There was a problem hiding this comment.
Fixing transition that wasn't working anymore.
| ? moduleOptions.pluralLabel | ||
| : moduleOptions.label; | ||
| ? labels.pluralLabel | ||
| : labels.label; |
There was a problem hiding this comment.
We know use moduleLabels if existing.
| ? this.checkedRelatedTypes.length * CONTAINER_ITEM_HEIGHT + CONTAINER_DESCRIPTION_HEIGHT | ||
| : CONTAINER_MINIMUM_HEIGHT; | ||
|
|
||
| await this.$nextTick(); |
There was a problem hiding this comment.
It worked until now because we make an http request before. But without the ref container isn't accessible.
Just a guard to make sure it'll work whatever time takes the request.
|
|
||
| 100% { | ||
| height: var(--container-height); | ||
| } |
There was a problem hiding this comment.
Fixing broken animation.
10 tasks
haroun
previously approved these changes
Jan 9, 2025
ValJed
force-pushed
the
pro-6870-export-templates
branch
from
76160dd to
d460c75
Compare
haroun
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRO-6871
PRO-6870
PRs
Summary
What are the specific steps to test this change?
Cypress tests: 🟠
What kind of change does this PR introduce?
Make sure the PR fulfills these requirements: