-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add csv and xlsx formats #61
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ETLaurent
commented
Apr 11, 2024
canImport(req, docType) { | ||
return self.canImportOrExport(req, docType, 'import'); | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved to import.js
ETLaurent
commented
Apr 11, 2024
canImport(req, docType) { | ||
return self.canImportOrExport(req, docType, 'import'); | ||
}, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
moved from export.js
boutell
approved these changes
Apr 24, 2024
tests run in https://github.com/apostrophecms/testbed/pull/242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Untie gzip method to build something more agnostic in order to be able to add other formats (such as formats which do not have multiple compressed files, but just a simple export file, like a CSV file for instance).
Add CSV format.
XLSX is added via a separate module: https://github.com/apostrophecms/import-export-xlsx (see PR).
Non-exhaustive list of the work done to separate concerns:
gzip
format and format-specific files handling on apostrophe side (ie: concerns are separated)Other improvements:
format.input()
call, whether it is called withoverrideLocale: true
or notremove
functions into one (except in gzip format where the remove function is standalone)[import]
and[export]
)[csv]
,[gzip]
,[xlsx]
)What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information: