ROVER-288 Ensure recomposition when supergraph.yaml is fixed
#2362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: f2aed25bb50ba4039059285f |
jonathanrainer
force-pushed
the
jr/task/ROVER-288
branch
from
ad7c135 to
beda7e6
Compare
dotdat
approved these changes
Jan 21, 2025
Under the previous scheme, if a `supergraph.yaml` ended up in a state where it can't be parsed, once it was fixed there would be no recomposition, so no clearing of errors or respecting the fix that had been made. This is now resolved.
jonathanrainer
force-pushed
the
jr/task/ROVER-288
branch
from
beda7e6 to
d838577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under the previous scheme, if a
supergraph.yamlended up in a state where it can't be parsed, once it was fixed there would be no recomposition, so no clearing of errors or respecting the fix that had been made. This is now resolved.