ROVER-286 Removing routing_url gives correct error message
#2360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: f74d9e135f1afc5fe8d93c81 |
jonathanrainer
commented
Jan 17, 2025
jonathanrainer
force-pushed
the
jr/task/ROVER-280
branch
from
3145bae to
547d269
Compare
jonathanrainer
force-pushed
the
jr/task/ROVER-286
branch
from
8bb1f76 to
941370d
Compare
There seems to have been a thought that a subgraph should be considered added and removed if the `routing_url` changes. That is not a good idea and is now reverted.
In the past we considered a FullyResolvedSupergraphConfig to be forced to have a routing_url for each subgraph. While this is technically a reasonable assumption, from the POV of the LSP it's actually better to enable it to be an Option<String> instead. This means we can more accurately funnel errors from the `supergraph` binary rather than having to do a lot of error handling ourselves.
Now that we've allowed `routing_url` to be an Option, we can address the crux of the issue by updating a routing_url midstream.
jonathanrainer
force-pushed
the
jr/task/ROVER-286
branch
from
941370d to
9b2d53f
Compare
jonathanrainer
commented
Jan 21, 2025
There was a problem hiding this comment.
It seems that at some point I thought that the pair of name and routing_url should uniquely identify a subgraph but that's nonsense and changing this doesn't break anything so I'm planning on reverting this and leaving it.
dotdat
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per title, due to some particularly inconvenient handling of federation resolution subgraphs losing a routing_url while the LSP was running, or not having one to start with were causing us many problems. This is now resolved and I've run over the test suite we have and all tests are passing (with the exception of the
--profileones, which are a known issue).Some comments are added throughout to explain the decisions taken.