ROVER-280 Fix Adding Subgraphs Semantics #2358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: ffe0af57163e926db9ef5a7e |
jonathanrainer
force-pushed
the
jr/task/ROVER-280
branch
from
29e99f2 to
6be7af9
Compare
jonathanrainer
force-pushed
the
jr/task/ROVER-281
branch
from
321821d to
a20cdae
Compare
In the original code even though we reported errors with and the subgraph was ostensibly "removed", it was retained inside an internal data structure within the SupergraphConfigWatcher and so when changes were made they were not seen properly and thus not acted on.
Before we had heavy use of abort handles which didn't give an opportunity to exit gracefully in many situations. These have been replaced with CancellationTokens, which also means we can guarantee that we get a shutdown on file watchers when the task that owns them shuts down.
jonathanrainer
force-pushed
the
jr/task/ROVER-280
branch
from
3145bae to
547d269
Compare
jonathanrainer
changed the title
nmoutschen
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the original code even though we reported errors with and the subgraph was ostensibly "removed", it was retained inside an internal data structure within the SupergraphConfigWatcher and so when changes were made they were not seen properly and thus not acted on.
In addition there were issues with adding a subgraph where file watchers were getting dropped too early, because of the use of a DropGuard in one of the Watcher objects, I've removed this idiom and instead added a series of cancellation tokens throughout, rather than relying on abort handles. This has the added benefit that cancellation is much more controlled and cascades in a better way than consistently trying to ensure all the right abort handles get called.