Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch invalid fields of literal objects #6707

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

dylan-apollo
Copy link
Member

Causes a composition error in URIs/headers/body when a literal object has a property accessed which doesn't exist.

This is taken from the name resolution code, but has no impact on non-literals right now since there's no resolution yet.

@dylan-apollo dylan-apollo requested a review from a team as a code owner January 30, 2025 21:53
@svc-apollo-docs
Copy link
Collaborator

svc-apollo-docs commented Jan 30, 2025

✅ Docs preview has no changes

The preview was not built because there were no changes.

Build ID: 45d88d878c69c77134c09e11

Copy link
Contributor

@dylan-apollo, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

Copy link
Member

@benjamn benjamn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More tests would be great, but this change makes sense to me.

@dylan-apollo
Copy link
Member Author

@benjamn I added cases for subselection, in addition to the path that was there, and both sub and path within a nested array.

I think that covers the main places this new function is used, but are there any others you can think of we should cover?

@dylan-apollo dylan-apollo merged commit 6e99471 into dev Jan 31, 2025
15 of 16 checks passed
@dylan-apollo dylan-apollo deleted the dylan/error-when-object-is-missing-property branch January 31, 2025 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants