feat(federation): query plan correctness checker #6498
+3,511
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs preview readyThe preview is ready to be viewed. View the preview File Changes 0 new, 1 changed, 0 removedBuild ID: 789e8fe275ae195cd6ad8cda URL: https://www.apollographql.com/docs/deploy-preview/789e8fe275ae195cd6ad8cda |
|
@duckki, please consider creating a changeset entry in |
|
CI performance tests
|
duckki
force-pushed
the
duckki/correctness
branch
from
a910d24 to
bcb23f4
Compare
duckki
changed the title
duckki
force-pushed
the
duckki/correctness
branch
3 times, most recently
from
2632b38 to
38bb635
Compare
lrlna
reviewed
Jan 13, 2025
Comment on lines
132
to
155
| // These two intersections are distinct type conditions. | ||
| // - `U ∧ I` = {R, S} | ||
| // - `U ∧ J` = `U` = {R, S, X} | ||
| let op_str = r#" | ||
| query { | ||
| test_u { | ||
| ... on I { | ||
| data(arg: 0) | ||
| } | ||
| ... on J { | ||
| data(arg: 0) | ||
| } | ||
| } | ||
| } | ||
| "#; | ||
| // Note: The set {R, S} has no corresponding named type definition in the schema, while | ||
| // `U ∧ J` is just the same as `U`. | ||
| insta::assert_snapshot!(response_shape(op_str), @r###" | ||
| { | ||
| test_u -----> test_u { | ||
| data -may-> data(arg: 0) on I ∧ U = {R, S} | ||
| data -may-> data(arg: 0) on U | ||
| } | ||
| } |
There was a problem hiding this comment.
This needs a bit of clarification, or more clearly named types. It becomes confusing to reason about single letter types in sets and intersections 😅 . For example, we can use the Pet schema that graphql js uses, or expand on the startstuff schema to add more unions?
Also, what does the -----> actually denote in these snapshots? I take it -may-> is an option? So, test_u has two possible options?
There was a problem hiding this comment.
I wrote some design doc (google doc).
- implemented ResponseShape computation from an operation
- comparison of two response shapes - query plans analysis, deriving plan's overall response shape
- instead of federation internal error
…ated data structures
…tions unnecessarily
duckki
force-pushed
the
duckki/correctness
branch
from
e1bd353 to
294c280
Compare
- API schema is necessary to parse the input operation.
- support multiple nested TypenameEqual elements for FetchDataRewrite - added more error cases for sanity check
duckki
requested review from
dariuszkuc,
sachindshinde,
goto-bus-stop,
SimonSapin and
TylerBloom
as code owners
duckki
changed the title
|
I have finished the first version (the completeness checking part) and rebased it on more recent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the first version of the query plan correctness checker.
It implemented the completeness part of the plan. I'll create a separate PR for the soundness part.
Status