feat(telemetry): add ability to set span attributes on connector span #6125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Benjamin <[email protected]>
✅ Docs Preview ReadyNo new or changed pages found. |
6 tasks
bnjjj
commented
Oct 7, 2024
| @@ -124,6 +124,9 @@ impl tower::Service<ConnectRequest> for ConnectorService { | |||
| "apollo.connector.source.detail" = tracing::field::Empty, | |||
| "apollo_private.sent_time_offset" = fetch_time_offset, | |||
| ); | |||
| // TODO: I think we should get rid of these attributes by default and only add it from custom telemetry. We just need to double check it's not required for Studio. | |||
There was a problem hiding this comment.
cc @timbotnik I need your knowledge here
pubmodmatt
reviewed
Oct 8, 2024
apollo-router/src/plugins/telemetry/config_new/connector/events.rs
Outdated
Show resolved
Hide resolved
…graphql/router into bnjjj/connectors/spans
6 tasks
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
Signed-off-by: Benjamin <[email protected]>
pubmodmatt
approved these changes
Oct 29, 2024
There was a problem hiding this comment.
This looks really good! Just a couple minor comments. It enables some nice things:
telemetry:
instrumentation:
spans:
connector:
attributes:
connector.url.template: true
connector.http.method: true
"rate_limit":
connector_http_response_header: "x-ratelimit-remaining"Signed-off-by: Benjamin <[email protected]>
Geal
approved these changes
Oct 30, 2024
Signed-off-by: Benjamin <[email protected]>
pubmodmatt
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Give the ability to use custom telemetry with spans for connectors.
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩