Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use LatestFedTwo as default federation version #591

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dotdat
Copy link
Contributor

@dotdat dotdat commented Oct 10, 2024

Makes FederationVersion::LatestFedTwo the default. This is to make sure we are looking forward to the future versions of composition as best as possible.

@dotdat dotdat requested review from a team as code owners October 10, 2024 17:56
@dylan-apollo
Copy link
Member

I think this would end up being a breaking change for customers, where if they don't have a specific federation version set in their supergraph.yaml, we're suddenly going to start upgrading them to fed 2 mode, right?

@dariuszkuc
Copy link
Member

Wondering whether latest is the right default, i.e. we definitely want to update the default to 2.x but I'd argue that we probably would want to target something like latest-1 (or some fixed fed version) for stability purposes.

Since we were defaulting to fed 1, customers wouldn't be using any fed 2 features so technically we could point to just to fed 2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants