Remove lock from OptimisticCache and unmerge it from MemoryCache #5662
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A followup to #5651.
I reverted the merge of OptimisticCache with MemoryCache after all, as doing the same with SqlCache would duplicate the code for no good reason. The important change was to remove the use of a lock, using
ConcurrentHashMap
instead (JVM only).While the benchmarks tended to show some improvement with the MemoryCache, the same change here with SqlCache seems to make no significant impact: