Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IJ plugin] Use apollo-debug-server to retrieve normalized caches #5348

Merged
merged 2 commits into from
Nov 6, 2023

Conversation

BoD
Copy link
Contributor

@BoD BoD commented Nov 3, 2023

Screen.Recording.2023-11-03.at.14.48.46.mov

@BoD BoD force-pushed the ij-plugin-cache-viewer-use-apollo-debug branch from aa59fb4 to 0a391b6 Compare November 3, 2023 19:30
Base automatically changed from apollo-debug-server to main November 6, 2023 10:23
@BoD BoD force-pushed the ij-plugin-cache-viewer-use-apollo-debug branch from 0a391b6 to 8bc6d9f Compare November 6, 2023 11:09
Copy link

netlify bot commented Nov 6, 2023

Deploy Preview for apollo-android-docs canceled.

Name Link
🔨 Latest commit 8d84efc
🔍 Latest deploy log https://app.netlify.com/sites/apollo-android-docs/deploys/6548eb3ebe4a1e0008b47956

@BoD BoD changed the base branch from main to root-types-args November 6, 2023 11:47
Base automatically changed from root-types-args to main November 6, 2023 13:30
@BoD BoD force-pushed the ij-plugin-cache-viewer-use-apollo-debug branch from 8bc6d9f to 8d84efc Compare November 6, 2023 13:33
Copy link
Contributor

@martinbonnin martinbonnin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Comment on lines +232 to +235
introspection {
endpointUrl.set("http://localhost:12200/")
schemaFile.set(file("../libraries/apollo-debug-server/src/androidMain/resources/schema.graphqls"))
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need introspection for this given that the schema is checked in source control?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really, but it's handy because it allows the IJ plugin to be configured with a URL, then we can execute queries in-IDE.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 oohoho I see 👍 . The introspection {} block is a bit misleading here, maybe we could rework that later... Anyways, cool stuff 👍

@BoD BoD merged commit 9c1fd7b into main Nov 6, 2023
9 checks passed
@BoD BoD deleted the ij-plugin-cache-viewer-use-apollo-debug branch November 6, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants