fix: Multipart chunk content type #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Docs Preview ReadyNo new or changed pages found. |
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Deploy Preview for eclectic-pie-88a2ba ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AnthonyMDev
approved these changes
Jan 8, 2025
Tests/ApolloTests/Interceptors/MultipartResponseSubscriptionParserTests.swift
Outdated
Show resolved
Hide resolved
BobaFetters
pushed a commit
that referenced
this pull request
Jan 8, 2025
BobaFetters
pushed a commit
to apollographql/apollo-ios
that referenced
this pull request
Jan 8, 2025
BobaFetters
pushed a commit
that referenced
this pull request
Jan 8, 2025
c17bddf2 fix: Multipart chunk content type (#572) a94ebd7a Update ROADMAP.md git-subtree-dir: apollo-ios git-subtree-split: c17bddf2f9ec626c70890fe203c382bd470749ec
BobaFetters
pushed a commit
that referenced
this pull request
Jan 8, 2025
git-subtree-dir: apollo-ios git-subtree-mainline: 492fdb8 git-subtree-split: c17bddf2f9ec626c70890fe203c382bd470749ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3495.
Refactored the parsing of
content-typeto handle multiple directives, which resolved the bug but also removed duplicated code. and allows for all directives to be used.